Re: svn commit: r934179 - in /ofbiz/trunk/framework/base: build.xml src/org/ofbiz/base/util/Assert.java src/org/ofbiz/base/util/test/AssertTests.java

2010-04-14 Thread Adrian Crum
ed, 4/14/10, Bob Morley wrote: > From: Bob Morley > Subject: Re: svn commit: r934179 - in /ofbiz/trunk/framework/base: build.xml > src/org/ofbiz/base/util/Assert.java > src/org/ofbiz/base/util/test/AssertTests.java > To: dev@ofbiz.apache.org > Date: Wednesday, A

Re: svn commit: r934179 - in /ofbiz/trunk/framework/base: build.xml src/org/ofbiz/base/util/Assert.java src/org/ofbiz/base/util/test/AssertTests.java

2010-04-14 Thread Bob Morley
Adrian Crum wrote: > >> Comments are welcome. > Your first mistake! heh It does not appear my trunk checkout has these classes in them ... I am guessing that the use here is in standard classes (not in junit testers). If you have a second to look at my patch associated with OFBIZ-3670; I pro

Re: svn commit: r934179 - in /ofbiz/trunk/framework/base: build.xml src/org/ofbiz/base/util/Assert.java src/org/ofbiz/base/util/test/AssertTests.java

2010-04-14 Thread Adrian Crum
Okay, that's weird. I just realized my revert didn't revert anything. Adrian Crum wrote: I'm thinking about putting this back in. The Validate syntax seems kind of clunky to me. I despise re-inventing the wheel, but at the same time I liked my syntax better. Using Validate: public void myMe

Re: svn commit: r934179 - in /ofbiz/trunk/framework/base: build.xml src/org/ofbiz/base/util/Assert.java src/org/ofbiz/base/util/test/AssertTests.java

2010-04-14 Thread Adrian Crum
I'm thinking about putting this back in. The Validate syntax seems kind of clunky to me. I despise re-inventing the wheel, but at the same time I liked my syntax better. Using Validate: public void myMethod(Object foo, Object bar) { Validate.notNull(foo); Validate.notNull(bar); //