Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml

2010-07-08 Thread Hans Bakker
Ok Scott asked me to reply. i do not have the time and even the knowledge to fix this. i opted to revert to 'double' here what was the quickest, however i agree not the perfect solution. Regards, Hans On Tue, 2010-07-06 at 20:37 +1200, Scott Gray wrote: If there is a risk of rounding errors

Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml

2010-07-08 Thread BJ Freeman
please open a Jira with steps to create error. maybe someone that has time will fix it. so I suggest revert in svn change it in your local copy. Hans Bakker sent the following on 7/8/2010 5:28 AM: Ok Scott asked me to reply. i do not have the time and even the knowledge to fix this. i opted

Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml

2010-07-06 Thread Hans Bakker
I agree with you, however the problem here is that the fields in the database are strings and can only be converted automatically in minilanguage to double. If Bigdecimal is used the log is full of conversion errors. I see no easy way to correct it and i do not have much time at the moment, you

Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml

2010-07-06 Thread Scott Gray
If there is a risk of rounding errors then I would argue that error messages in the logs are a much better alternative than hiding the problem. Regards Scott On 6/07/2010, at 7:15 PM, Hans Bakker wrote: I agree with you, however the problem here is that the fields in the database are strings

Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml

2010-07-06 Thread Adrian Crum
: From: Scott Gray scott.g...@hotwaxmedia.com Subject: Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml To: dev@ofbiz.apache.org Date: Tuesday, July 6, 2010, 1:37 AM If there is a risk of rounding errors then I would argue

Re: svn commit: r960502 - /ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/timesheet/TimesheetServices.xml

2010-07-05 Thread BJ Freeman
it seems there was a big effort to make everything bigdecimal to avoid calculation errors. I can see the reason to change this just because a log create an error. it would seem more productive to solve the problem with the log. = BJ Freeman