[GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...

2018-07-31 Thread yonigottesman
Github user yonigottesman commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/39#discussion_r206463065 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -298,26 +291,62 @@ public CommitTimestamp

[GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...

2018-07-31 Thread yonigottesman
Github user yonigottesman commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/39#discussion_r206463988 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -298,26 +295,58 @@ public CommitTimestamp

[GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...

2018-07-31 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/39#discussion_r206422618 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -395,8 +427,8 @@ private Get

[GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...

2018-07-31 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/39#discussion_r206422025 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -298,26 +291,62 @@ public CommitTimestamp

[GitHub] incubator-omid pull request #39: [OMID-105] When a tentative family deletion...

2018-07-31 Thread yonigottesman
Github user yonigottesman commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/39#discussion_r206462235 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java --- @@ -298,26 +295,58 @@ public CommitTimestamp

[jira] [Commented] (OMID-107) Replace HTableInterface with Table

2018-07-31 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/OMID-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563909#comment-16563909 ] James Taylor commented on OMID-107: --- OmidTransactionTable constructs a TTable by passing in an

[jira] [Closed] (OMID-106) Delete does not use write timestamp after checkpoint

2018-07-31 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ohad Shacham closed OMID-106. - > Delete does not use write timestamp after checkpoint >

[jira] [Closed] (OMID-105) Family deletion seek should continue when a tentative value is found

2018-07-31 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ohad Shacham closed OMID-105. - > Family deletion seek should continue when a tentative value is found >

[jira] [Resolved] (OMID-106) Delete does not use write timestamp after checkpoint

2018-07-31 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ohad Shacham resolved OMID-106. --- Resolution: Fixed > Delete does not use write timestamp after checkpoint >

[jira] [Commented] (OMID-105) Family deletion seek should continue when a tentative value is found

2018-07-31 Thread Yonatan Gottesman (JIRA)
[ https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563501#comment-16563501 ] Yonatan Gottesman commented on OMID-105: looks good > Family deletion seek should continue when a

[jira] [Commented] (OMID-105) Family deletion seek should continue when a tentative value is found

2018-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563497#comment-16563497 ] ASF GitHub Bot commented on OMID-105: - Github user ohadshacham commented on a diff in the pull request:

[jira] [Commented] (OMID-105) Family deletion seek should continue when a tentative value is found

2018-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563406#comment-16563406 ] ASF GitHub Bot commented on OMID-105: - Github user yonigottesman commented on a diff in the pull

[jira] [Commented] (OMID-105) Family deletion seek should continue when a tentative value is found

2018-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563404#comment-16563404 ] ASF GitHub Bot commented on OMID-105: - Github user yonigottesman commented on a diff in the pull

[jira] [Commented] (OMID-105) Family deletion seek should continue when a tentative value is found

2018-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563405#comment-16563405 ] ASF GitHub Bot commented on OMID-105: - Github user yonigottesman commented on a diff in the pull

[jira] [Commented] (OMID-106) Delete does not use write timestamp after checkpoint

2018-07-31 Thread Yonatan Gottesman (JIRA)
[ https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563380#comment-16563380 ] Yonatan Gottesman commented on OMID-106: looks good > Delete does not use write timestamp after

[jira] [Commented] (OMID-106) Delete does not use write timestamp after checkpoint

2018-07-31 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563327#comment-16563327 ] Ohad Shacham commented on OMID-106: --- Bug was identified in PHOENIX-4783. > Delete does not use write

[jira] [Commented] (OMID-108) TTable should support batch method

2018-07-31 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563260#comment-16563260 ] Ohad Shacham commented on OMID-108: --- We explicitly do a flush only before committing the transaction,

[jira] [Commented] (OMID-107) Replace HTableInterface with Table

2018-07-31 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563255#comment-16563255 ] Ohad Shacham commented on OMID-107: --- It does use  HTableInterace inside TTable. > Replace

[jira] [Commented] (OMID-105) Family deletion seek should continue when a tentative value is found

2018-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563251#comment-16563251 ] ASF GitHub Bot commented on OMID-105: - Github user ohadshacham commented on a diff in the pull request: