Github user yonigottesman commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/39#discussion_r206463065
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java
---
@@ -298,26 +291,62 @@ public CommitTimestamp
Github user yonigottesman commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/39#discussion_r206463988
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java
---
@@ -298,26 +295,58 @@ public CommitTimestamp
Github user ohadshacham commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/39#discussion_r206422618
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java
---
@@ -395,8 +427,8 @@ private Get
Github user ohadshacham commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/39#discussion_r206422025
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java
---
@@ -298,26 +291,62 @@ public CommitTimestamp
Github user yonigottesman commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/39#discussion_r206462235
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/SnapshotFilterImpl.java
---
@@ -298,26 +295,58 @@ public CommitTimestamp
[
https://issues.apache.org/jira/browse/OMID-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563909#comment-16563909
]
James Taylor commented on OMID-107:
---
OmidTransactionTable constructs a TTable by passing in an
[
https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ohad Shacham closed OMID-106.
-
> Delete does not use write timestamp after checkpoint
>
[
https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ohad Shacham closed OMID-105.
-
> Family deletion seek should continue when a tentative value is found
>
[
https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ohad Shacham resolved OMID-106.
---
Resolution: Fixed
> Delete does not use write timestamp after checkpoint
>
[
https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563501#comment-16563501
]
Yonatan Gottesman commented on OMID-105:
looks good
> Family deletion seek should continue when a
[
https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563497#comment-16563497
]
ASF GitHub Bot commented on OMID-105:
-
Github user ohadshacham commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563406#comment-16563406
]
ASF GitHub Bot commented on OMID-105:
-
Github user yonigottesman commented on a diff in the pull
[
https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563404#comment-16563404
]
ASF GitHub Bot commented on OMID-105:
-
Github user yonigottesman commented on a diff in the pull
[
https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563405#comment-16563405
]
ASF GitHub Bot commented on OMID-105:
-
Github user yonigottesman commented on a diff in the pull
[
https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563380#comment-16563380
]
Yonatan Gottesman commented on OMID-106:
looks good
> Delete does not use write timestamp after
[
https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563327#comment-16563327
]
Ohad Shacham commented on OMID-106:
---
Bug was identified in PHOENIX-4783.
> Delete does not use write
[
https://issues.apache.org/jira/browse/OMID-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563260#comment-16563260
]
Ohad Shacham commented on OMID-108:
---
We explicitly do a flush only before committing the transaction,
[
https://issues.apache.org/jira/browse/OMID-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563255#comment-16563255
]
Ohad Shacham commented on OMID-107:
---
It does use HTableInterace inside TTable.
> Replace
[
https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563251#comment-16563251
]
ASF GitHub Bot commented on OMID-105:
-
Github user ohadshacham commented on a diff in the pull request:
19 matches
Mail list logo