Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/46#discussion_r224179421
--- Diff:
hbase-client/src/test/java/org/apache/omid/transaction/TestOmidLLRaces.java ---
@@ -0,0 +1,243 @@
+/*
+ * Licensed to the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/41#discussion_r207918413
--- Diff:
hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java ---
@@ -227,24 +252,26 @@ private static boolean endsWith(byte
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/41#discussion_r207918920
--- Diff:
hbase-client/src/main/java/org/apache/omid/transaction/HTableAccessWrapper.java
---
@@ -20,10 +20,7 @@
import
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/41#discussion_r207919955
--- Diff:
hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestSnapshotFilter.java
---
@@ -226,8 +222,115 @@ public void
Github user JamesRTaylor commented on the issue:
https://github.com/apache/incubator-omid/pull/41
Nice work, @yonigottesman. I made a few minor comments, @ohadshacham. My
main question is do the Phoenix unit tests
FlappingTransactionIT.testInflightUpdateNotSeen() and
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/41#discussion_r207921192
--- Diff:
hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java
---
@@ -0,0 +1,244
Github user JamesRTaylor commented on the issue:
https://github.com/apache/incubator-omid/pull/41
This is great, @yonigottesman! Do the Phoenix unit tests
FlappingTransactionIT.testInflightUpdateNotSeen() and
testInflightDeleteNotSeen() pass with this change? You can try running them
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/41#discussion_r206935434
--- Diff:
hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java
---
@@ -0,0 +1,248
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/41#discussion_r206936274
--- Diff:
hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java ---
@@ -52,6 +52,7 @@
static byte[] DELETE_TOMBSTONE
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/41#discussion_r206934998
--- Diff:
hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestSnapshotFilter.java
---
@@ -226,8 +222,115 @@ public void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-omid/pull/41#discussion_r206927180
--- Diff:
hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java
---
@@ -0,0 +1,248
Github user JamesRTaylor commented on the issue:
https://github.com/apache/incubator-omid/pull/36
+1
---
Github user JamesRTaylor commented on the issue:
https://github.com/apache/incubator-omid/pull/35
+1
---
Github user JamesRTaylor commented on the issue:
https://github.com/apache/incubator-omid/pull/24
Changes look good. Couple of minor nits:
* Instead of excluding .md, why not just add the ASF header?
* Do you want to have rat automatically run by mvn when you get ready to do
a
14 matches
Mail list logo
