[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473439#comment-16473439
]
Yonatan Gottesman commented on OMID-44:
---
+1
> Add reference to Yahoo code in NOTICE file
>
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462153#comment-16462153
]
Ohad Shacham commented on OMID-44:
--
[~jmclean], could you please review? Thx!
> Add reference to Yahoo code
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457941#comment-16457941
]
Ohad Shacham commented on OMID-44:
--
[~jamestaylor], the latest version of the NOTICE file is at:
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457123#comment-16457123
]
James Taylor commented on OMID-44:
--
[~ohads] - is the the current, latest version of the NOTICE file:
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453757#comment-16453757
]
Ohad Shacham commented on OMID-44:
--
[~jmclean], could you please review? I updated the year and made it as
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424626#comment-16424626
]
Justin Mclean commented on OMID-44:
---
Sorry I obviously need more coffee, what you done is correct and what
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424623#comment-16424623
]
Justin Mclean commented on OMID-44:
---
" and the links I've previously provided." I mean.
> Add reference to
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424621#comment-16424621
]
Justin Mclean commented on OMID-44:
---
Why has Yahoo been added to the NOTICE file? This is not the correct
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423600#comment-16423600
]
Ohad Shacham commented on OMID-44:
--
Thx!
> Add reference to Yahoo code in NOTICE file
>
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423599#comment-16423599
]
ASF GitHub Bot commented on OMID-44:
Github user ohadshacham closed the pull request at:
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422556#comment-16422556
]
James Taylor commented on OMID-44:
--
+1
> Add reference to Yahoo code in NOTICE file
>
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422236#comment-16422236
]
Ohad Shacham commented on OMID-44:
--
Can anyone please review?
> Add reference to Yahoo code in NOTICE file
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413568#comment-16413568
]
Ohad Shacham commented on OMID-44:
--
[~jmclean], Could you please review?
Thx!
> Add reference to Yahoo
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413566#comment-16413566
]
ASF GitHub Bot commented on OMID-44:
GitHub user ohadshacham opened a pull request:
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417671#comment-15417671
]
ASF GitHub Bot commented on OMID-44:
GitHub user francisco-perez-sorrosal opened a pull request:
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352615#comment-15352615
]
Flavio Junqueira commented on OMID-44:
--
Next release sounds fine with me.
> Add reference to Yahoo code
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351381#comment-15351381
]
Francisco Perez-Sorrosal commented on OMID-44:
--
No objections here.
These classes are not core
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350290#comment-15350290
]
Daniel Dai commented on OMID-44:
As this is not a blocking issue for 0.8.2.0 releaes, I'd like to resolve it
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350019#comment-15350019
]
Daniel Dai commented on OMID-44:
Compared the files with YCSB2, here is where these files coming from:
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349522#comment-15349522
]
Flavio Junqueira commented on OMID-44:
--
Thanks for bringing this up [~jmclean]. There are two references
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349518#comment-15349518
]
Justin Mclean commented on OMID-44:
---
BTW the text should be what in the original NOTICE file. I find it a
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349516#comment-15349516
]
Justin Mclean commented on OMID-44:
---
Up to you. IMO it's fine to fix in the next release or a later one as
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348992#comment-15348992
]
Justin Mclean commented on OMID-44:
---
IMO (with my incubator hat on) it looks to me that this has been
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340531#comment-15340531
]
Daniel Dai commented on OMID-44:
+1
> Add reference to Yahoo code in NOTICE file
>
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340525#comment-15340525
]
Francisco Pérez-Sorrosal commented on OMID-44:
--
I guess you can +1 and commit
--
Francisco
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340518#comment-15340518
]
Daniel Dai commented on OMID-44:
Are we waiting for [~alangates]'s review on the revert?
> Add reference to
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336997#comment-15336997
]
Francisco Perez-Sorrosal commented on OMID-44:
--
The pull request for the revert is in here:
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336773#comment-15336773
]
Alan Gates commented on OMID-44:
Relevant documents I found on this:
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336565#comment-15336565
]
Flavio Junqueira commented on OMID-44:
--
Ok, so maybe [~alangates] missed that it had the Apache License
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336434#comment-15336434
]
Francisco Perez-Sorrosal commented on OMID-44:
--
When [~alangates] voted -1 on Jun 6 at 11:55 AM
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336097#comment-15336097
]
Flavio Junqueira commented on OMID-44:
--
I'm confused about this issue. The files you're mentioning above
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323404#comment-15323404
]
Igor Katkov commented on OMID-44:
-
+1
> Add reference to Yahoo code in NOTICE file
>
[
https://issues.apache.org/jira/browse/OMID-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317227#comment-15317227
]
Francisco Perez-Sorrosal commented on OMID-44:
--
PR submitted to
33 matches
Mail list logo