Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL

2012-03-14 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4358/ --- Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Ben

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

2012-03-14 Thread brian Foster
> On 2012-03-14 16:05:06, Paul Ramirez wrote: > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java, > > line 47 > > > > > > shouldn't this be: > > > > return Boolean.getBoolean(System.

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

2012-03-14 Thread Paul Ramirez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4326/#review5943 --- Ship it! That was the only change I saw. Otherwise looks good. trun

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

2012-03-14 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4326/#review5960 --- Ship it! LGTM! - Chris On 2012-03-14 05:18:33, brian Foster wrote:

Re: Review Request: Convert CAS-PGE metadata keys and workflow statuses from static Strings to enums

2012-03-14 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4326/#review5959 --- trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKe

Re: Review Request: Drop Spring logging levels from WARNING to SEVERE

2012-03-14 Thread Paul Ramirez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4342/#review5942 --- Ship it! Looks good to me. Next time you can link this to the Jira is

Re: Review Request: Drop Spring logging levels from WARNING to SEVERE

2012-03-14 Thread Chris Mattmann
> On 2012-03-14 15:57:26, Paul Ramirez wrote: > > Looks good to me. Next time you can link this to the Jira issue if you want > > by putting the OODT-408 in the bugs field in the review request. +1! Also feel free to add me, or pramirez and rickdn as we all seem to be using RB too. It rox! -

Re: Review Request: Drop Spring logging levels from WARNING to SEVERE

2012-03-14 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4342/#review5946 --- In principal, looking good, you got all the logging.properties files,

Review Request: Drop Spring logging levels from WARNING to SEVERE

2012-03-14 Thread Thomas Bennett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4342/ --- Review request for oodt and brian Foster. Summary --- Drop Spring logging l