Re: Question about how to assign a port number to its protocol in pushpull

2012-08-08 Thread Mattmann, Chris A (388J)
Good job, YunHee! Can you submit a patch and file a JIRA issue with the below? Thanks! Cheers, Chris On Aug 8, 2012, at 8:10 AM, YunHee Kang wrote: > Hi Chris and Brian, > > I really appreciate your advice. According to Brian's guideline, I > did do that as follows: > First off, I modif

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-08 Thread Mattmann, Chris A (388J)
Good job, YunHee! Can you submit a patch and file a JIRA issue with the below? Thanks! Cheers, Chris On Aug 8, 2012, at 8:10 AM, YunHee Kang wrote: > Hi Chris and Brian, > > I really appreciate your advice. According to Brian's guideline, I > did do that as follows: > First off, I modif

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-08 Thread Brian Foster
hey yunhee,this implementation is a good start, but you need to put the property reading inside a constructor... there is a setter method in JschSftpProtocolFactory, and the way you have it, you will override any value set there by reading the java property in newInstance().-brianOn Aug 08, 2012, a

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-08 Thread YunHee Kang
Hi Chris and Brian, I really appreciate your advice. According to Brian's guideline, I did do that as follows: First off, I modified the method newInstance of the class JschSftpProtocolFactory as follows: public class JschSftpProtocolFactory implements ProtocolFactory { public static fina

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-07 Thread Mattmann, Chris A (388J)
+1 from me, Brian! Cheers, Chris On Aug 6, 2012, at 11:15 AM, Brian Foster wrote: > > yunhee, > > let actually make the property name: > > org.apache.oodt.cas.protocol.jsch.sftp.port > > what you think chris? > > -brian > > On Aug 06, 2012, at 10:52 AM, Brian Foster wrote: > >> hey yunhe

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-06 Thread Brian Foster
yunhee,let actually make the property name:org.apache.oodt.cas.protocol.jsch.sftp.portwhat you think chris?-brianOn Aug 06, 2012, at 10:52 AM, Brian Foster wrote:hey yunhee,like chris said i would use the java properties he defined and modify the following class to set port to it by default to it:

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-06 Thread Brian Foster
hey yunhee,like chris said i would use the java properties he defined and modify the following class to set port to it by default to it:https://svn.apache.org/repos/asf/oodt/trunk/protocol/sftp/src/main/java/org/apache/oodt/cas/protocol/sftp/JschSftpProtocolFactory.javayour change would probably lo

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-06 Thread Mattmann, Chris A (388J)
Hi YunHee, On Aug 6, 2012, at 5:20 AM, YunHee Kang wrote: > Hi Chris, > > I am writing to you to ask you about how to apply a port number in a > property file of the pushpull framework. > Until now I didn't find how to do that in the push-pull user manual > written by Brian. > > I think that we