Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-09 Thread brian Foster
> On 2012-04-04 02:12:41, Paul Ramirez wrote: > > trunk/pge/src/main/resources/examples/PgeConfigFiles/pge-config.xml, lines > > 42-43 > > > > > > Put these examples inside comment tags as they wouldn't work as they > >

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-05 Thread brian Foster
> On 2012-04-04 18:34:56, Chris Mattmann wrote: > > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, line > > 151 > > > > > > this seems like an ancillary change to this patch. However, it's a > > u

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-05 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/#review6735 --- Ship it! LGTM sounds good. - Chris On 2012-04-06 02:16:10, brian F

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-05 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/#review6734 --- Ship it! - Chris On 2012-04-06 02:16:10, brian Foster wrote: > > -

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-05 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/ --- (Updated 2012-04-06 02:16:10.469275) Review request for oodt, Chris Mattmann, Ri

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-05 Thread brian Foster
> On 2012-04-04 02:12:41, Paul Ramirez wrote: > > trunk/pge/src/main/resources/examples/Crawler/action-beans.xml, lines 29-37 > > > > > > I'd define these properties in another file and then include them here. > > This is

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-04 Thread Paul Ramirez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/#review6670 --- trunk/pge/src/main/resources/examples/Crawler/action-beans.xml

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-04 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/#review6694 --- Ship it! LGTM, minor comments on my end. Great work. This will cause

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-04 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/#review6686 --- trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java

Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-03 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/ --- Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas B