Re: Review Request: Port wengine ControlMetadata to cas-pge's PgeMetadata

2012-03-12 Thread Paul Ramirez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4269/#review5850 --- Ship it! Love the varargs! - Paul On 2012-03-10 01:32:07, brian

Re: Review Request: Port wengine ControlMetadata to cas-pge's PgeMetadata

2012-03-12 Thread brian Foster
On 2012-03-10 17:49:33, Chris Mattmann wrote: trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, line 453 https://reviews.apache.org/r/4269/diff/2/?file=90993#file90993line453 Why not commit all keys -- or, maybe I am reading this wrong? if you don't specify

Re: Review Request: Port wengine ControlMetadata to cas-pge's PgeMetadata

2012-03-10 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4269/#review5819 --- trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java

Re: Review Request: Port wengine ControlMetadata to cas-pge's PgeMetadata

2012-03-10 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4269/#review5821 --- Ship it! My comments are SUPER minor. This rocks. My +1 to ship it.