[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262594#comment-16262594 ] Hadoop QA commented on OOZIE-3132: -- Testing JIRA OOZIE-3132 Cleaning local git workspace

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-22 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262588#comment-16262588 ] Andras Piros commented on OOZIE-3132: - Thanks [~gezapeti] and [~pbacsko] for the revie

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-22 Thread Peter Cseh (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262524#comment-16262524 ] Peter Cseh commented on OOZIE-3132: --- Thanks for the double check :) Go ahead and commit

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-22 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262517#comment-16262517 ] Andras Piros commented on OOZIE-3132: - [~gezapeti] there are some new {{TRACE}} level

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-22 Thread Peter Cseh (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262481#comment-16262481 ] Peter Cseh commented on OOZIE-3132: --- This is a good improvement for supportability. [~an

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-22 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262447#comment-16262447 ] Andras Piros commented on OOZIE-3132: - Thanks for the review [~pbacsko]! [~gezapeti]

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-22 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262440#comment-16262440 ] Peter Bacsko commented on OOZIE-3132: - +1 LGTM, please ask Geza to take a look at it,

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-21 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261322#comment-16261322 ] Andras Piros commented on OOZIE-3132: - {{TestMetricsInstrumentation#testJMXInstrumenta

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261027#comment-16261027 ] Hadoop QA commented on OOZIE-3132: -- Testing JIRA OOZIE-3132 Cleaning local git workspace

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260958#comment-16260958 ] Hadoop QA commented on OOZIE-3132: -- Testing JIRA OOZIE-3132 Cleaning local git workspace

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-21 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260741#comment-16260741 ] Andras Piros commented on OOZIE-3132: - [~pbacsko] thanks for the review! Uploading new

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-20 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259129#comment-16259129 ] Peter Bacsko commented on OOZIE-3132: - There's a typo here: "An instance ofSLACalcStat

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-20 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259121#comment-16259121 ] Peter Bacsko commented on OOZIE-3132: - Or, even a {{set()}} method could make sense.

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-20 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259117#comment-16259117 ] Peter Bacsko commented on OOZIE-3132: - {{instrumentation.incr(INSTRUMENTATION_GROUP, S

[jira] [Commented] (OOZIE-3132) Instrument SLACalculatorMemory

2017-11-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/OOZIE-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258219#comment-16258219 ] Hadoop QA commented on OOZIE-3132: -- Testing JIRA OOZIE-3132 Cleaning local git workspace