See <https://builds.apache.org/job/oozie-trunk-precommit-build/3593/>
------------------------------------------ [...truncated 7337 lines...] Reports Running test-patch task CLEAN Running test-patch task RAW_PATCH_ANALYSIS Running test-patch task RAT Running test-patch task JAVADOC Running test-patch task COMPILE Running test-patch task FINDBUGS_DIFF [TRACE] Downloading FindBugs diff JAR from https://repo1.maven.org/maven2/me/andrz/findbugs/findbugs-diff/0.1.0/findbugs-diff-0.1.0-all.jar [TRACE] FindBugs diff JAR downloaded grep: <https://builds.apache.org/job/oozie-trunk-precommit-build/ws/bin/findbugs-diff-0.1.0-all.jar.md5sum>: No such file or directory [TRACE] FindBugs diff JAR checked, is safe to use [TRACE] Performing FindBugs diffs bin/test-patch-11-findbugs-diff: line 248: : No such file or directory bin/test-patch-11-findbugs-diff: line 250: [: -le: unary operator expected Exception in thread "main" groovy.lang.GroovyRuntimeException: Ambiguous method overloading for method java.io.File#<init>. Cannot resolve which method to invoke for [null] due to overlapping prototypes between: [class java.lang.String] [class java.net.URI] at groovy.lang.MetaClassImpl.chooseMostSpecificParams(MetaClassImpl.java:3202) at groovy.lang.MetaClassImpl.chooseMethodInternal(MetaClassImpl.java:3154) at groovy.lang.MetaClassImpl.chooseMethod(MetaClassImpl.java:3097) at groovy.lang.MetaClassImpl.createConstructorSite(MetaClassImpl.java:3384) at org.codehaus.groovy.runtime.callsite.CallSiteArray.createCallConstructorSite(CallSiteArray.java:88) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:57) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:182) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:190) at me.andrz.findbugs.diff.FindBugsDiff.diffFromFilePaths(FindBugsDiff.groovy:33) at me.andrz.findbugs.diff.FindBugsDiff$diffFromFilePaths.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:120) at me.andrz.findbugs.diff.FindBugsDiffIo.run(FindBugsDiffIo.groovy:21) at me.andrz.findbugs.diff.FindBugsDiffIo$run.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:45) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:116) at me.andrz.findbugs.diff.FindBugsDiffCli.handleFileOpts(FindBugsDiffCli.groovy:75) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90) at org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrapNoCoerce.invoke(StaticMetaMethodSite.java:148) at org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.callStatic(StaticMetaMethodSite.java:99) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallStatic(CallSiteArray.java:53) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:157) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:169) at me.andrz.findbugs.diff.FindBugsDiffCli.main(FindBugsDiffCli.groovy:51) [TRACE] FindBugs diffs performed [TRACE] Checking FindBugs diffs and creating reports [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [server]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [client]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [docs]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/hive]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/spark]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/hcatalog]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/hive2]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/streaming]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/pig]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/sqoop]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/distcp]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [sharelib/oozie]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [DEBUG] There are no new bugs found in [hadooplibs/hadoop-utils-2]. [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [ERROR] There are [42] new bugs found below threshold in [core]. [DEBUG] You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html [TRACE] New XMLLib present, calling 'xmllint --xpath' to get bug instance counts [ERROR] There are [6] new bugs found below threshold in [tools]. [DEBUG] You can find the FindBugs diff here (look for the red and orange ones): tools/findbugs-new.html [ERROR] There are [48] new bugs found below threshold in total that must be fixed. [TRACE] FindBugs diffs checked and reports created [TRACE] File [<https://builds.apache.org/job/oozie-trunk-precommit-build/ws/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar]> removed [TRACE] File [<https://builds.apache.org/job/oozie-trunk-precommit-build/ws/test-patch/tmp/FINDBUGS_DIFF/diff/findbugs-diff-0.1.0-all.jar.md5sum]> removed Running test-patch task BACKWARDS_COMPATIBILITY Running test-patch task TESTS Running test-patch task DISTRO Testing JIRA OOZIE-2781 Cleaning local git workspace ---------------------------- +1 PATCH_APPLIES +1 CLEAN -1 RAW_PATCH_ANALYSIS +1 the patch does not introduce any @author tags +1 the patch does not introduce any tabs +1 the patch does not introduce any trailing spaces -1 the patch contains 3 line(s) longer than 132 characters +1 the patch does adds/modifies 1 testcase(s) +1 RAT +1 the patch does not seem to introduce new RAT warnings +1 JAVADOC +1 the patch does not seem to introduce new Javadoc warnings -1 COMPILE +1 HEAD compiles -1 patch does not compile +1 the patch does not seem to introduce new javac warnings -1 There are [48] new bugs found below threshold in total that must be fixed. +1 There are no new bugs found in [server]. +1 There are no new bugs found in [client]. +1 There are no new bugs found in [docs]. +1 There are no new bugs found in [sharelib/hive]. +1 There are no new bugs found in [sharelib/spark]. +1 There are no new bugs found in [sharelib/hcatalog]. +1 There are no new bugs found in [sharelib/hive2]. +1 There are no new bugs found in [sharelib/streaming]. +1 There are no new bugs found in [sharelib/pig]. +1 There are no new bugs found in [sharelib/sqoop]. +1 There are no new bugs found in [sharelib/distcp]. +1 There are no new bugs found in [sharelib/oozie]. +1 There are no new bugs found in [hadooplibs/hadoop-utils-2]. -1 There are [42] new bugs found below threshold in [core] that must be fixed. You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html The most important FindBugs errors are: At OozieDBCLI.java:[line 548]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInMysql(String, Connection): new java.io.FileWriter(String, boolean) At OozieDBCLI.java:[line 577]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInPostgres(String, Connection, String): new java.io.FileWriter(String, boolean) At OozieDBCLI.java:[line 983]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.createOozieSysTable(String, boolean, String): new java.io.FileWriter(String, boolean) At OozieDBCLI.java:[line 759]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.ddlTweaks(String, boolean): new java.io.FileWriter(String, boolean) At OozieDBCLI.java:[line 712]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.ddlTweaksFor50(String, boolean, String): new java.io.FileWriter(String, boolean) At OozieDBCLI.java:[line 344]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.postUpgradeTasks(String, boolean, boolean): new java.io.FileWriter(String, boolean) At OozieDBCLI.java:[line 420]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.postUpgradeTasksFor40(String, boolean): new java.io.FileWriter(String, boolean) At OozieDBCLI.java:[line 258]: Found reliance on default encoding in org.apache.oozie.tools.OozieDBCLI.upgradeOozieDBVersion(String, boolean, String): new java.io.FileWriter(String, boolean) At OozieDBCLI.java:[line 679]: org.apache.oozie.tools.OozieDBCLI.getAddColumnQuery(String, String, String) invokes inefficient new String(String) constructor At OozieDBCLI.java:[line 675]: org.apache.oozie.tools.OozieDBCLI.getDropColumnQuery(String, String) invokes inefficient new String(String) constructor At OozieDBCLI.java:[line 671]: org.apache.oozie.tools.OozieDBCLI.getRenameColumnQuery(String, String, String) invokes inefficient new String(String) constructor At OozieDBCLI.java:[line 69]: org.apache.oozie.tools.OozieDBCLI.HELP_INFO should be package protected Obligation to clean up resource created at OozieDBCLI.java:[line 721] is not discharged: org.apache.oozie.tools.OozieDBCLI.ddlTweaksFor50(String, boolean, String) may fail to clean up java.sql.Statement Path continues at OozieDBCLI.java:[line 728]: Path continues at OozieDBCLI.java:[line 722] Path continues at OozieDBCLI.java:[line 730]: Path continues at OozieDBCLI.java:[line 729] org.apache.oozie.tools.OozieDBCLI.checkDBExists() may fail to clean up java.sql.ResultSet on checked exception: Path continues at OozieDBCLI.java:[line 734] Path continues at OozieDBCLI.java:[line 892]: Obligation to clean up resource created at OozieDBCLI.java:[line 891] is not discharged Path continues at OozieDBCLI.java:[line 898]: Path continues at OozieDBCLI.java:[line 897] org.apache.oozie.tools.OozieDBCLI.checkDBExists() may fail to clean up java.sql.Statement on checked exception: Path continues at OozieDBCLI.java:[line 901] Path continues at OozieDBCLI.java:[line 891]: Obligation to clean up resource created at OozieDBCLI.java:[line 890] is not discharged Path continues at OozieDBCLI.java:[line 897]: Path continues at OozieDBCLI.java:[line 892] Path continues at OozieDBCLI.java:[line 901]: Path continues at OozieDBCLI.java:[line 898] Obligation to clean up resource created at OozieDBCLI.java:[line 550] is not discharged: org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInMysql(String, Connection) may fail to clean up java.sql.Statement on checked exception Path continues at OozieDBCLI.java:[line 552]: Path continues at OozieDBCLI.java:[line 551] Path continues at OozieDBCLI.java:[line 554]: Path continues at OozieDBCLI.java:[line 553] Path continues at OozieDBCLI.java:[line 556]: Path continues at OozieDBCLI.java:[line 555] Path continues at OozieDBCLI.java:[line 560]: Path continues at OozieDBCLI.java:[line 559] Path continues at OozieDBCLI.java:[line 562]: Path continues at OozieDBCLI.java:[line 561] Obligation to clean up resource created at OozieDBCLI.java:[line 998] is not discharged: org.apache.oozie.tools.OozieDBCLI.createOozieSysTable(String, boolean, String) may fail to clean up java.sql.Statement on checked exception Path continues at OozieDBCLI.java:[line 1007]: Path continues at OozieDBCLI.java:[line 999] Path continues at OozieDBCLI.java:[line 1011]: Path continues at OozieDBCLI.java:[line 1008] org.apache.oozie.tools.OozieDBCLI.ddlTweaks(String, boolean) may fail to clean up java.sql.Statement on checked exception: Path continues at OozieDBCLI.java:[line 1012] Path continues at OozieDBCLI.java:[line 835]: Obligation to clean up resource created at OozieDBCLI.java:[line 834] is not discharged Path continues at OozieDBCLI.java:[line 856]: Path continues at OozieDBCLI.java:[line 855] Obligation to clean up resource created at OozieDBCLI.java:[line 946] is not discharged: org.apache.oozie.tools.OozieDBCLI.getOozieDBVersion() may fail to clean up java.sql.ResultSet on checked exception Path continues at OozieDBCLI.java:[line 956]: Path continues at OozieDBCLI.java:[line 947] Path continues at OozieDBCLI.java:[line 960]: Path continues at OozieDBCLI.java:[line 957] Obligation to clean up resource created at OozieDBCLI.java:[line 945] is not discharged: org.apache.oozie.tools.OozieDBCLI.getOozieDBVersion() may fail to clean up java.sql.Statement on checked exception Path continues at OozieDBCLI.java:[line 947]: Path continues at OozieDBCLI.java:[line 946] Path continues at OozieDBCLI.java:[line 957]: Path continues at OozieDBCLI.java:[line 956] org.apache.oozie.tools.OozieDBCLI.postUpgradeTasks(String, boolean, boolean) may fail to clean up java.sql.Statement on checked exception: Path continues at OozieDBCLI.java:[line 960] Path continues at OozieDBCLI.java:[line 354]: Obligation to clean up resource created at OozieDBCLI.java:[line 353] is not discharged Path continues at OozieDBCLI.java:[line 414]: Path continues at OozieDBCLI.java:[line 413] Obligation to clean up resource created at OozieDBCLI.java:[line 435] is not discharged: org.apache.oozie.tools.OozieDBCLI.postUpgradeTasksFor40(String, boolean) may fail to clean up java.sql.Statement on checked exception Path continues at OozieDBCLI.java:[line 448]: Path continues at OozieDBCLI.java:[line 436] org.apache.oozie.tools.OozieDBCLI.showOozieSysInfo() may fail to clean up java.sql.ResultSet on checked exception: Path continues at OozieDBCLI.java:[line 449] Path continues at OozieDBCLI.java:[line 1029]: Obligation to clean up resource created at OozieDBCLI.java:[line 1028] is not discharged Path continues at OozieDBCLI.java:[line 1038]: Path continues at OozieDBCLI.java:[line 1037] org.apache.oozie.tools.OozieDBCLI.showOozieSysInfo() may fail to clean up java.sql.Statement on checked exception: Path continues at OozieDBCLI.java:[line 1041] Path continues at OozieDBCLI.java:[line 1028]: Obligation to clean up resource created at OozieDBCLI.java:[line 1027] is not discharged Path continues at OozieDBCLI.java:[line 1037]: Path continues at OozieDBCLI.java:[line 1029] Path continues at OozieDBCLI.java:[line 1041]: Path continues at OozieDBCLI.java:[line 1038] Obligation to clean up resource created at OozieDBCLI.java:[line 268] is not discharged: org.apache.oozie.tools.OozieDBCLI.upgradeOozieDBVersion(String, boolean, String) may fail to clean up java.sql.Statement on checked exception Path continues at OozieDBCLI.java:[line 273]: Path continues at OozieDBCLI.java:[line 269] Path continues at OozieDBCLI.java:[line 277]: Path continues at OozieDBCLI.java:[line 274] Obligation to clean up resource created at OozieDBCLI.java:[line 1050] is not discharged: org.apache.oozie.tools.OozieDBCLI.verifyDBState() may fail to clean up java.sql.ResultSet on checked exception Path continues at OozieDBCLI.java:[line 1062]: Path continues at OozieDBCLI.java:[line 1051] Obligation to clean up resource created at OozieDBCLI.java:[line 1049] is not discharged: org.apache.oozie.tools.OozieDBCLI.verifyDBState() may fail to clean up java.sql.Statement on checked exception Path continues at OozieDBCLI.java:[line 1051]: Path continues at OozieDBCLI.java:[line 1050] org.apache.oozie.tools.OozieDBCLI.verifyOozieSysTable(boolean, boolean) may fail to clean up java.sql.ResultSet on checked exception: Path continues at OozieDBCLI.java:[line 1062] Path continues at OozieDBCLI.java:[line 920]: Obligation to clean up resource created at OozieDBCLI.java:[line 919] is not discharged Path continues at OozieDBCLI.java:[line 926]: Path continues at OozieDBCLI.java:[line 925] org.apache.oozie.tools.OozieDBCLI.verifyOozieSysTable(boolean, boolean) may fail to clean up java.sql.Statement on checked exception: Path continues at OozieDBCLI.java:[line 929] Path continues at OozieDBCLI.java:[line 919]: Obligation to clean up resource created at OozieDBCLI.java:[line 918] is not discharged Path continues at OozieDBCLI.java:[line 925]: Path continues at OozieDBCLI.java:[line 920] Path continues at OozieDBCLI.java:[line 929]: Path continues at OozieDBCLI.java:[line 926] At OozieDBCLI.java:[line 721]: org.apache.oozie.tools.OozieDBCLI.ddlTweaksFor50(String, boolean, String) may fail to close Statement At OozieDBCLI.java:[line 460]: org.apache.oozie.tools.OozieDBCLI.replaceForDerby(String, String) may fail to close Statement At OozieDBCLI.java:[line 1003]: org.apache.oozie.tools.OozieDBCLI.createOozieSysTable(String, boolean, String) passes a nonconstant String to an execute method on an SQL statement At OozieDBCLI.java:[line 269]: org.apache.oozie.tools.OozieDBCLI.upgradeOozieDBVersion(String, boolean, String) passes a nonconstant String to an execute method on an SQL statement At OozieDBCLI.java:[line 562]: org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInMysql(String, Connection) passes a nonconstant String to an execute method on an SQL statement At OozieDBCLI.java:[line 604]: org.apache.oozie.tools.OozieDBCLI.convertClobToBlobInPostgres(String, Connection, String) passes a nonconstant String to an execute method on an SQL statement Another occurrence at OozieDBCLI.java:[line 606]: Another occurrence at OozieDBCLI.java:[line 605] org.apache.oozie.tools.OozieDBCLI.postUpgradeTasks(String, boolean, boolean) passes a nonconstant String to an execute method on an SQL statement: Another occurrence at OozieDBCLI.java:[line 607] Exception is caught when Exception is not thrown in org.apache.oozie.tools.OozieDBExportCLI.queryAllDBTables(String): At OozieDBCLI.java:[line 401] Exceptional return value of java.io.File.delete() ignored in org.apache.oozie.tools.OozieDBExportCLI.queryAllDBTables(String): At OozieDBExportCLI.java:[line 162] Boxing/unboxing to parse a primitive org.apache.oozie.tools.OozieSharelibCLI.run(String[]): At OozieDBExportCLI.java:[line 168] org.apache.oozie.tools.OozieSharelibCLI.HELP_INFO should be package protected: At OozieSharelibCLI.java:[line 114] Exceptional return value of java.io.File.delete() ignored in org.apache.oozie.tools.OozieSharelibCLI.run(String[]): At OozieSharelibCLI.java:[line 51] Exceptional return value of java.io.File.mkdir() ignored in org.apache.oozie.tools.OozieSharelibCLI.run(String[]): At OozieSharelibCLI.java:[line 138] At OozieSharelibCLI.java:[line 139] -1 There are [6] new bugs found below threshold in [tools] that must be fixed. You can find the FindBugs diff here (look for the red and orange ones): tools/findbugs-new.html The most important FindBugs errors are: At DateList.java:[line 55]: Nullcheck of date at line 55 of value previously dereferenced in org.apache.oozie.example.DateList.main(String[]) Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called: Redundant null check at DateList.java:[line 62] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to clean up java.io.InputStream: At DateList.java:[line 97] Path continues at LocalOozieExample.java:[line 76]: Obligation to clean up resource created at LocalOozieExample.java:[line 72] is not discharged Path continues at LocalOozieExample.java:[line 78]: Path continues at LocalOozieExample.java:[line 77] Path continues at LocalOozieExample.java:[line 88]: Path continues at LocalOozieExample.java:[line 81] Path continues at LocalOozieExample.java:[line 91]: Path continues at LocalOozieExample.java:[line 89] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to close stream: Path continues at LocalOozieExample.java:[line 100] org.apache.oozie.example.Repeatable.getBaseline() may expose internal representation by returning Repeatable.baseline: At LocalOozieExample.java:[line 72] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose internal representation by storing an externally mutable object into Repeatable.baseline: At Repeatable.java:[line 168] At Repeatable.java:[line 172] +1 BACKWARDS_COMPATIBILITY +1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations +1 the patch does not modify JPA files -1 TESTS - patch does not compile, cannot run testcases -1 DISTRO -1 distro tarball fails with the patch ---------------------------- -1 Overall result, please check the reported -1(s) The full output of the test-patch run is available at https://builds.apache.org/job/oozie-trunk-precommit-build/3593/ Adding comment to JIRA Comment added. test-patch exit code: 1 Build step 'Execute shell' marked build as failure Archiving artifacts Compressed 841.29 KB of artifacts by 22.8% relative to #3565 Recording test results
