Re: Review Request: OOZIE-1186 Image load for Job DAG visualization should handle resources better

2013-01-24 Thread Virag Kothari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9079/#review15679 --- Ship it! +1..Good to know about dispose(). It seems we misread the j

Re: Review Request: OOZIE-1186 Image load for Job DAG visualization should handle resources better

2013-01-24 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9079/ --- (Updated Jan. 25, 2013, 3:46 a.m.) Review request for oozie. Changes ---

Re: Review Request: OOZIE-1186 Image load for Job DAG visualization should handle resources better

2013-01-24 Thread Virag Kothari
> On Jan. 24, 2013, 8:22 p.m., Virag Kothari wrote: > > trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java, > > line 113 > > > > > > The test case fails/passes inconsistently. > > I also tried w

Re: Review Request: OOZIE-1186 Image load for Job DAG visualization should handle resources better

2013-01-24 Thread Mona Chitnis
> On Jan. 24, 2013, 8:22 p.m., Virag Kothari wrote: > > trunk/core/src/test/java/org/apache/oozie/util/TestGraphGenerator.java, > > line 113 > > > > > > The test case fails/passes inconsistently. > > I also tried w

Re: Review Request: OOZIE-1186 Image load for Job DAG visualization should handle resources better

2013-01-24 Thread Virag Kothari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9079/#review15651 --- trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java

Re: Review Request: OOZIE-1186 Image load for Job DAG visualization should handle resources better

2013-01-24 Thread Rohini Palaniswamy
> On Jan. 24, 2013, 5:33 p.m., Rohini Palaniswamy wrote: > > trunk/core/src/main/java/org/apache/oozie/util/GraphGenerator.java, line 263 > > > > > > Can we also add a out = null after close. > > > > http://wik

Re: Review Request: OOZIE-1186 Image load for Job DAG visualization should handle resources better

2013-01-24 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9079/#review15647 --- Looks good. Just need one minor change to deal with java bug. trun

Review Request: OOZIE-1186 Image load for Job DAG visualization should handle resources better

2013-01-23 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9079/ --- Review request for oozie. Description --- https://issues.apache.org/jira/br