Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review40408 --- Ship it! Ship It! - Rohini Palaniswamy On April 15, 2014, 12:16

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/ --- (Updated April 15, 2014, 12:16 a.m.) Review request for oozie. Changes --

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review40089 --- Ship it! Looks good. Please remove the unused method in the final p

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

> On April 10, 2014, 6:18 p.m., Bowen Zhang wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, > > line 549 > > > > > > Cannot assume frequency is an integer. If the frequency is cr

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

> On April 10, 2014, 5:41 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, > > line 261 > > > > > > Changing both endtime and pausetime do not work with c

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/ --- (Updated April 10, 2014, 7:42 p.m.) Review request for oozie. Changes ---

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review40051 --- core/src/main/java/org/apache/oozie/command/coord/CoordChangeXComma

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review40011 --- core/src/main/java/org/apache/oozie/command/coord/CoordChangeXComma

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/ --- (Updated April 9, 2014, 11:57 p.m.) Review request for oozie. Changes ---

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

> On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java, > > line 240 > > > > > > Why change this? Because job start time is 2009-0

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review39830 --- core/src/main/java/org/apache/oozie/command/coord/CoordChangeXComma

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/ --- (Updated April 8, 2014, 5:28 p.m.) Review request for oozie. Changes ---

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/ --- (Updated April 4, 2014, 10:25 p.m.) Review request for oozie. Changes ---

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review38352 --- core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeX

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review39346 --- core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeX

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java, > > line 102 > > > > > > The check is valid. Please revert this. If the bu

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/ --- (Updated March 31, 2014, 5:31 p.m.) Review request for oozie. Changes ---

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, > > line 358 > > > > > > Why do we need this? Looks like you have added this t

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review37475 --- core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeX

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

> On Feb. 19, 2014, 11:34 p.m., Mona Chitnis wrote: > > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java, > > line 102 > > > > > > We should atleast check for DateUtils.parseDate(endTime

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review37269 --- The unit test does not test for bundle status being updated to SUSPE

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/ --- (Updated Feb. 21, 2014, 10:26 p.m.) Review request for oozie. Bugs: OOZIE-170

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review34940 --- BundleStartXCommand's verifyPrecondition() needs to be changed as we

Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/#review34943 --- Now i'm also thinking if we should set bundle/coord status for this

Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18257/ --- Review request for oozie. Bugs: OOZIE-1703 https://issues.apache.org/jira/b