Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review46036 --- Ship it! Ship It! - shwethags On June 17, 2014, 11:01 a.m., Sati

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/ --- (Updated June 17, 2014, 11:01 a.m.) Review request for oozie, Ryota Egashira an

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

> On June 17, 2014, 6:37 a.m., shwethags wrote: > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, line 303 > > > > > > There should be validation on type in the beginning of the function Added valida

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review45914 --- core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

> On June 16, 2014, 2:02 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, lines > > 293-298 > > > > > > Can you put this code in if (type equals hive-export) block?

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/ --- (Updated June 16, 2014, 1:09 p.m.) Review request for oozie, Ryota Egashira and

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review45732 --- core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review45715 --- core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/ --- (Updated June 13, 2014, 5:40 p.m.) Review request for oozie, Ryota Egashira and

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/ --- (Updated April 8, 2014, 6:38 p.m.) Review request for oozie, Ryota Egashira and

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/ --- (Updated April 3, 2014, 7:02 p.m.) Review request for oozie and Ryota Egashira.

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

> On March 28, 2014, 6:54 p.m., Rohini Palaniswamy wrote: > > We should call it dataInPartition as it only works if there is one > > partition. > > > > I like the idea of the generalization, but I can't seem to be able to think > > of another use case where the current generalization will act

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

> On March 28, 2014, 6:54 p.m., Rohini Palaniswamy wrote: > > We should call it dataInPartition as it only works if there is one > > partition. > > > > I like the idea of the generalization, but I can't seem to be able to think > > of another use case where the current generalization will act

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

> On March 28, 2014, 6:54 p.m., Rohini Palaniswamy wrote: > > We should call it dataInPartition as it only works if there is one > > partition. > > > > I like the idea of the generalization, but I can't seem to be able to think > > of another use case where the current generalization will act

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

> On March 28, 2014, 6:54 p.m., Rohini Palaniswamy wrote: > > We should call it dataInPartition as it only works if there is one > > partition. > > > > I like the idea of the generalization, but I can't seem to be able to think > > of another use case where the current generalization will act

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review38930 --- We should call it dataInPartition as it only works if there is one p

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/ --- (Updated March 28, 2014, 12:38 p.m.) Review request for oozie and Ryota Egashir

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

> On March 24, 2014, 7:11 p.m., Ryota Egashira wrote: > > in addition to rohini's comment. > > how about making it more generic EL funct, where user can specify > > separator(e.,g ',' 'AND' 'OR') and equal symbol (e.g, '=', '==', etc) in > > argument?, since there could be new requirement in fu

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review38343 --- in addition to rohini's comment. how about making it more generic EL

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

> On March 20, 2014, 4:57 p.m., Rohini Palaniswamy wrote: > > What is the expected string to be returned from the function, when the > > data-in has current(0) to current(-23)? Can you give some examples where > > more than one instance of the dataset is involved? Hi, This function is intended

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review37909 --- What is the expected string to be returned from the function, when t

Re: Review Request 19449: OOZIE-1741: Add new coord EL function to get input partitions value string

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/ --- (Updated March 20, 2014, 6 a.m.) Review request for oozie and Ryota Egashira.