Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-09-10 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review53004 --- Ship it! Ship It! - Purshotam Shah On Sept. 10, 2014, 9:02 a.m.,

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-09-10 Thread shwetha . gs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/ --- (Updated Sept. 10, 2014, 9:02 a.m.) Review request for oozie. Bugs: OOZIE-195

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-09-10 Thread shwetha . gs
> On Sept. 8, 2014, 6:50 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/util/Pair.java, line 73 > > > > > > 1. > > If first!=null and otherPair.first=null > > second=null and otherPair.secon

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-09-08 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review52619 --- core/src/main/java/org/apache/oozie/util/Pair.java

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-09-07 Thread shwetha . gs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/ --- (Updated Sept. 8, 2014, 6:15 a.m.) Review request for oozie. Changes ---

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-09-07 Thread shwetha . gs
> On Aug. 29, 2014, 7:14 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 36 > > > > > > [INFO] | | +- org.apache.commons:commons-lang3:jar:3.1:provided > > can y

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-29 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review51896 --- core/src/main/java/org/apache/oozie/CoordinatorEngine.java

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-19 Thread shwetha . gs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/ --- (Updated Aug. 19, 2014, 8:37 a.m.) Review request for oozie. Changes ---

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-12 Thread shwetha . gs
> On Aug. 12, 2014, 6:08 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/DG_CommandLineTool.twiki, lines 59-60 > > > > > > Revert breaking into multiple lines. precommit build fails with longer line:( - shw

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-12 Thread shwetha . gs
> On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 37 > > > > > > Why Hbase util? This means that Oozie always need have hbase-*.jar, > > which migh

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-11 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review50292 --- Few minor comments. Also cannot use Pair from hbase and that needs t

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-11 Thread Rohini Palaniswamy
> On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 37 > > > > > > Why Hbase util? This means that Oozie always need have hbase-*.jar, > > which migh

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-08 Thread shwetha . gs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/ --- (Updated Aug. 8, 2014, 9:24 a.m.) Review request for oozie. Changes ---

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-08 Thread shwetha . gs
> On Aug. 8, 2014, 8:33 a.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 37 > > > > > > Why Hbase util? This means that Oozie always need have hbase-*.jar, > > which migh

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-08 Thread Rohini Palaniswamy
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > src/main/resources/checkstyle.xml, line 31 > > > > > > Where is this property defined? Not able to find it in code base. > > shwethags wrote: > in main po

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-08 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review50019 --- core/src/main/java/org/apache/oozie/CoordinatorEngine.java

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-08 Thread shwetha . gs
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/DG_CommandLineTool.twiki, line 45 > > > > > > Below changes can make the help a little more clear. > > > > - The comparators are

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-08 Thread Rohini Palaniswamy
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > src/main/resources/checkstyle.xml, line 31 > > > > > > Where is this property defined? Not able to find it in code base. > > shwethags wrote: > in main po

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-07 Thread shwetha . gs
> On Aug. 7, 2014, 8:34 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java, > > lines 126-127 > > > > > > To be removed yes, will remove >

Re: Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-07 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review49880 --- client/src/main/java/org/apache/oozie/client/OozieClient.java

Review Request 24299: OOZIE-1950 Coordinator job info should support timestamp (nominal time)

2014-08-04 Thread shwetha . gs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/ --- Review request for oozie. Bugs: OOZIE-1950 https://issues.apache.org/jira/b