Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Rohini Palaniswamy
> On Jan. 25, 2016, 10:24 p.m., Rohini Palaniswamy wrote: > > Please create a separate jira for documentation - Rohini --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review116181

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/ --- (Updated Jan. 25, 2016, 11:32 p.m.) Review request for oozie. Bugs:

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Rohini Palaniswamy
> On Dec. 30, 2015, 6:01 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordOldInputDependency.java, > > line 140 > > > > > > Should be

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Rohini Palaniswamy
> On Dec. 29, 2015, 10:05 p.m., Rohini Palaniswamy wrote: > > client/src/main/resources/oozie-coordinator-0.5.xsd, line 115 > > > > > > type="coordinator:IDENTIFIER" . Same for other names. > > > >

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Purshotam Shah
> On Dec. 29, 2015, 10:05 p.m., Rohini Palaniswamy wrote: > > client/src/main/resources/oozie-coordinator-0.5.xsd, line 115 > > > > > > type="coordinator:IDENTIFIER" . Same for other names. > > > >

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review116181 --- core/src/main/java/org/apache/oozie/coord/CoordELConstants.java

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/ --- (Updated Jan. 26, 2016, 12:08 a.m.) Review request for oozie. Bugs:

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/ --- (Updated Jan. 26, 2016, 12:15 a.m.) Review request for oozie. Bugs:

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review116226 --- Ship it! Ship It! - Rohini Palaniswamy On Jan. 26, 2016,

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-25 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review116227 --- Ship it! Ship It! - Rohini Palaniswamy On Jan. 26, 2016,

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-07 Thread Purshotam Shah
> On Dec. 30, 2015, 6:58 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java, > > line 1525 > > > > > > Why is this testcase removed? merge issue >

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-07 Thread Purshotam Shah
> On Dec. 30, 2015, 6:01 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/coord/input/dependency/CoordInputDependencyCheckPhaseOne.java, > > line 47 > > > > > > private not needed. removed.

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-07 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/ --- (Updated Jan. 8, 2016, 2:24 a.m.) Review request for oozie. Bugs: OOZIE-1976

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-07 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/ --- (Updated Jan. 8, 2016, 2:32 a.m.) Review request for oozie. Bugs: OOZIE-1976

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-07 Thread Purshotam Shah
> On Dec. 29, 2015, 10:05 p.m., Rohini Palaniswamy wrote: > > client/src/main/resources/oozie-coordinator-0.5.xsd, line 115 > > > > > > type="coordinator:IDENTIFIER" . Same for other names. > > > >

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2016-01-07 Thread Purshotam Shah
> On Oct. 9, 2015, 12:53 a.m., Robert Kanter wrote: > > client/src/main/resources/oozie-coordinator-0.5.xsd, line 110 > > > > > > Is there any way to enforce a max depth on nested "and"s and "or"s via > > the

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-12-30 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review112235 ---

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-12-30 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review112330 ---

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-12-29 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review112102 --- These are comments for Page 1 and 2. Still I have not fully gone

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-12-18 Thread Robert Kanter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review111340 --- client/src/main/resources/oozie-coordinator-0.5.xsd (line 19)

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-12-15 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/ --- (Updated Dec. 15, 2015, 7:33 p.m.) Review request for oozie. Bugs:

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-11-23 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/ --- (Updated Nov. 24, 2015, 1:17 a.m.) Review request for oozie. Bugs:

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-10-20 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review103325 --- Having a little trouble zero-ing in on the code that checks that

Re: Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-10-08 Thread Robert Kanter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/#review101982 --- As a general point, can you add some additional comments/javadoc?

Review Request 38474: OOZIE-1976- Specifying coordinator input datasets in more logical ways

2015-09-17 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38474/ --- Review request for oozie. Bugs: OOZIE-1976