Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review189417 --- Ship it! - Peter Bacsko On okt. 27, 2017, 10:01 de, András

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review189412 --- Ship it! Ship It! - Peter Cseh On Oct. 27, 2017, 10:01

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/ --- (Updated Oct. 27, 2017, 10:01 a.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 27, 2017, 9:04 a.m., Peter Cseh wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java > > Lines 316 (patched) > > > > > > Does this mean that we're not overwriting

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review189406 ---

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/ --- (Updated Oct. 26, 2017, 5:20 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 19, 2017, 3:03 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 133 (patched) > > > > > > Any plans to add this to the XML schema? Or it's

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 19, 2017, 3:03 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 133 (patched) > > > > > > Any plans to add this to the XML schema? Or it's

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 19, 2017, 2:10 p.m., Peter Bacsko wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherConfigurationInjector.java > > Lines 26 (patched) > > > > > > There are a lot of hard-coded stuff

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review188680 ---

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review188678 ---

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/ --- (Updated Oct. 19, 2017, 10:04 a.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On okt. 17, 2017, 3:19 du, András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java > > Lines 95-96 (patched) > > > > > > I'm really rather in favor of making

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/ --- (Updated Oct. 17, 2017, 3:25 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 17, 2017, 11:24 a.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationInjector.java > > Lines 256 (patched) > > > > > > So if we define

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review188316 ---

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review188290 ---

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/ --- (Updated Oct. 16, 2017, 4:19 p.m.) Review request for oozie, Attila Sasvari,

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 16, 2017, 12:51 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/LauncherConfigurationFilter.java > > Lines 29 (patched) > > > > > > Should we come up with some better name? >

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 12, 2017, 11:36 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Line 17 (original), 17 (patched) > > > > > > Don't forget to add documentation.

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review188120 ---

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 12, 2017, 11:36 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 1197 (patched) > > > > > > This is fine to leave for a different JIRA,

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

> On Oct. 12, 2017, 11:36 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 1197 (patched) > > > > > > This is fine to leave for a different JIRA,

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review187893 ---

Re: Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/#review187806 ---

Review Request 62936: OOZIE-2896 Ensure compatibility for existing LauncherMapper settings

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62936/ --- Review request for oozie, Attila Sasvari, Peter Cseh, and Peter Bacsko.