Re: Review Request 63836: OOZIE-2869 Ability to add/remove MapReduce jars from action classpath.

2017-11-16 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63836/#review191193 --- Ship it! Ship It! - András Piros On Nov. 15, 2017, 1:34 p.m.

Re: Review Request 63836: OOZIE-2869 Ability to add/remove MapReduce jars from action classpath.

2017-11-16 Thread Peter Cseh via Review Board
> On Nov. 15, 2017, 2:11 p.m., András Piros wrote: > > Would be advisable to have a test case covering different `needed.for` > > scenarios, that is, the new functionality. > > Peter Cseh wrote: > Yeah, I agree. I'm not sure I can test this properly. I'm opening up a > Jira to create an Ap

Re: Review Request 63836: OOZIE-2869 Ability to add/remove MapReduce jars from action classpath.

2017-11-16 Thread Peter Cseh via Review Board
> On Nov. 15, 2017, 2:11 p.m., András Piros wrote: > > Would be advisable to have a test case covering different `needed.for` > > scenarios, that is, the new functionality. Yeah, I agree. I'm not sure I can test this properly. I'm opening up a Jira to create an AppSubmissionContextFactory or s

Re: Review Request 63836: OOZIE-2869 Ability to add/remove MapReduce jars from action classpath.

2017-11-15 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63836/#review191060 --- Would be advisable to have a test case covering different `needed.

Review Request 63836: OOZIE-2869 Ability to add/remove MapReduce jars from action classpath.

2017-11-15 Thread Peter Cseh via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63836/ --- Review request for oozie. Bugs: OOZIE-2869 https://issues.apache.org/jira/b