Re: Openeb Box.

2007-08-05 Thread Mohammad Nour El-Din
Hi Karan... I will ask him to do so, and he is happy to do it for OpenEJB and Geronimo :D On 8/6/07, Karan Malhi <[EMAIL PROTECTED]> wrote: > > Hey Mohammad, > > Would it be possible to remove the whitespace from the image and > submit the new image. > And please convey our thanks to your brother

Re: Openeb Box.

2007-08-05 Thread Karan Malhi
Hey Mohammad, Would it be possible to remove the whitespace from the image and submit the new image. And please convey our thanks to your brother. On 7/1/07, Mohammad Nour El-Din <[EMAIL PROTECTED]> wrote: > :) sorry I didn't review, I will let my brother make it better > > On 6/28/07, David Blev

Re: i18n and logging

2007-08-05 Thread Karan Malhi
>we might even be able to > setup the root "OpenEJB" category as additivity=false as it is now we > could actually turn additivity back on on all the subcategories. > > What do you think? I agree,OpenEJB category should control all appenders. Will fix it and submit a patch. Also, I remember reading

Re: i18n and logging

2007-08-05 Thread Karan Malhi
Ok, got it. Will use it to update the logging documentation this week. On 8/5/07, David Blevins <[EMAIL PROTECTED]> wrote: > > On Aug 4, 2007, at 4:00 PM, Karan Malhi wrote: > > > We could javadoc the heck out of each > >> category and then include the source file in a page on the website > >> via

Re: i18n and logging

2007-08-05 Thread David Blevins
Moving the discussion back over to this thread (cleaner archives and all that). On Aug 5, 2007, at 2:39 PM, Karan Malhi wrote: Also, if you can review the Logger Categories, that would be nice. Some categories do not start with OpenEJB, and I was not sure about the reason behind it. One more

Re: i18n and logging

2007-08-05 Thread David Blevins
On Aug 4, 2007, at 4:00 PM, Karan Malhi wrote: We could javadoc the heck out of each category and then include the source file in a page on the website via the snippet plugin. Very cool. I don't know anything about the snippet plugin. Looks like something pretty useful , can you share some mo

Re: Please commit patch in OPENEJB-624 -- Thanks Karan!

2007-08-05 Thread Karan Malhi
Thanks David, I did not know what to write in the javadocs for each Logger Category. If we can write the javadocs, then using the confluence snippet plugin is a real neat thing. In fact, if we do it once (and I get to know how it was done), then we can identify some more areas of code which could

Re: Please commit patch in OPENEJB-624 -- Thanks Karan!

2007-08-05 Thread David Blevins
All committed! I swear, the idea sounded neat, but looking at it in the code it's just that much better. More comments on the thread where you proposed the idea. FYI, perfect sized change, very easy to review. I'm not always so great with my commits, but this is definitely the way to go

Re: OpenEJB & vmbuild

2007-08-05 Thread Brett Porter
Hi David, all, vmbuild1 is now set up. I have created a group for OpenEJB but have not added the projects. If you'd like to register for an account I can give you the group administration roles so that you can do this and assign rights to other users. http://vmbuild1.apache.org/continuu

Re: Please commit patch in OPENEJB-624

2007-08-05 Thread Karan Malhi
Anybody wants to take out some time to commit this patch. It won't take too much time to review it as all I have done is extracted Logger Categories to an interface and replaced existing instances of hard-coded Logger Categories with references to constants defined in the LogCategory interface. I

Please commit patch in OPENEJB-624

2007-08-05 Thread Karan Malhi
Could somebody please commit the patch in OPENEJB-624 ? Thanks -- Karan Singh Malhi

Re: help required with patch submission -- Thanks Karan!

2007-08-05 Thread Karan Malhi
Thanks David, > Just a note, seems in the standalone server most the log messages > wind up in system.out and not in the logs/openejb.log file. Still have to work on that. >It's totally cool if we have one log setup for embedded stuff (maven > building, etc.) and a different one for the standalon