Alright. Went ahead and re-rolled. This pushes us out to Monday for a vote close. Hopefully we don't have anymore issues.
At this point I'd say we should probably consider anything that isn't a serious regression as a good thing for next release. -David On Sep 28, 2012, at 1:51 AM, Romain Manni-Bucau wrote: > fixed on trunk and in the branch > > *Romain Manni-Bucau* > *Twitter: @rmannibucau* > *Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/> > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* > > > > > 2012/9/28 Romain Manni-Bucau <rmannibu...@gmail.com> > >> in Assembler.destroyApplication we skip global bindings for the app and >> instead we do: >> >> try { >> containerSystem.getJNDIContext().unbind("java:global"); >> } catch (NamingException ignored) { >> // no-op >> } >> >> shouldn't be done IMO (otherwise it means 1 app / container). >> >> wdyt? >> >> *Romain Manni-Bucau* >> *Twitter: @rmannibucau* >> *Blog: >> **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/> >> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* >> >> >> >> >> 2012/9/28 David Blevins <david.blev...@gmail.com> >> >>> TCK looks good. Builds fine. Works in Eclipse. Here's my +1! >>> >>> -David >>> >>> On Sep 27, 2012, at 12:46 PM, dblev...@apache.org wrote: >>> >>>> [generated email] >>>> >>>> SVN Tag: >>>> >>>> https://svn.apache.org/repos/asf/openejb/tags/openejb-4.5.0/ >>>> >>>> Maven Repo: >>>> >>>> https://repository.apache.org/content/repositories/orgapacheopenejb-053 >>>> >>>> Binaries & Source: >>>> >>>> http://people.apache.org/~dblevins/staging-053/openejb-4.5.0/ >>>> >>>> Legal: >>>> >>>> http://people.apache.org/~dblevins/staging-053/legal/archives.html >>>> >>>> >>>> Vote will be open for 72 hours or as needed. >>>> >>> >>> >>
