Re: Question on Persistence ref validation

2012-09-01 Thread Enrico Olivelli
I attached a patch (code + test) for this issue https://issues.apache.org/jira/browse/OPENEJB-731 It recognizes the most common usecase I think @PersistenceContext(unitName='someRESOURCE_LOCALunit EntityManager) does it work ? - Enrico Il 28/08/2012 05:59, David Blevins ha scritto: On Aug

Re: Question on Persistence ref validation

2012-09-01 Thread Romain Manni-Bucau
Sounds not bad for me. Note: we have some cool api to test validations maybe you can enhance the patch with such a test (rules package) Le 1 sept. 2012 15:40, Enrico Olivelli eolive...@gmail.com a écrit : I attached a patch (code + test) for this issue

Re: Question on Persistence ref validation

2012-09-01 Thread Enrico Olivelli
in the patch I attached a new test case in CheckPersistenceContextUsageTest that uses that API Il 01/09/2012 16:25, Romain Manni-Bucau ha scritto: Sounds not bad for me. Note: we have some cool api to test validations maybe you can enhance the patch with such a test (rules package) Le 1 sept.

Re: Question on Persistence ref validation

2012-09-01 Thread Romain Manni-Bucau
Just saw it. Seems almost perfect, just wonder is managedbean shouldnt be checked (cdi)...or if we shouldnt save this scanning if not done to avoid a long field browsing Le 1 sept. 2012 16:27, Enrico Olivelli eolive...@gmail.com a écrit : in the patch I attached a new test case in

Re: Question on Persistence ref validation

2012-08-27 Thread David Blevins
On Aug 26, 2012, at 11:06 PM, Enrico Olivelli wrote: I'm implementing https://issues.apache.org/jira/browse/OPENEJB-731 I'm adding it to: org.apache.openejb.config.rules.CheckPersistenceRefs but I think I need the real PersistenceUnit, what is the best way to get it ? The persistence-unit