Just a heads-up - I've expanded this and made sure it can deploy/undeploy
.wars, .jars and .ears. I've also moved it to its own module, which we can
add to TomEE as part of the TCK run. I'm going to try using it to run some
TCK tests locally and see how it gets on.
Jon
+1
- Romain
2011/11/8 David Blevins
>
> On Nov 8, 2011, at 5:53 AM, Romain Manni-Bucau wrote:
>
> > there are already several classes we could want to extract
> >
> > what i don't like with this ejb is it will be exposed to user since it is
> > loggued and not usable by him
>
> Maybe we need to
On Nov 8, 2011, at 5:53 AM, Romain Manni-Bucau wrote:
> there are already several classes we could want to extract
>
> what i don't like with this ejb is it will be exposed to user since it is
> loggued and not usable by him
Maybe we need to write in some sort of "hidden" flag and corresponding
there are already several classes we could want to extract
what i don't like with this ejb is it will be exposed to user since it is
loggued and not usable by him
--
View this message in context:
http://openejb.979440.n4.nabble.com/Webapp-deployer-tp3997059p4016040.html
Sent from the OpenEJB De
Hum, creating a separate module would be clearer may be, but just for one
simple class
I would choose the simple solution which is, AFAIK to add it to the core or
elsewhere.
JLouis
2011/11/7 David Blevins
> As long as we can run both the Java EE and CDI TCKs with the webapps dir
> approa
As long as we can run both the Java EE and CDI TCKs with the webapps dir
approach I don't care where the code lives -- it's just one class so far.
Note the CDI TCK doesn't use the VmDeployer.
-David
On Monday, November 7, 2011, Romain Manni-Bucau
wrote:
> yep, exactly,
>
> this deployer doesn't
yep, exactly,
this deployer doesn't give any feature to the user or to us to be honest,
it is just common for us but we doesn't need it because the code is really
simple and could be part of the VmDeployer impl.
So yes a separated module can be better...
maybe i'm alone to think it so feel free
Are you thinking you'd prefer the deployer to be part of the tck, or a
module in its own right?
I don't have a strong view either way, as long as the TCK setup is doing
the right thing. Maybe our Arquillian adapters should be using this method
as well?
Jon
On Nov 7, 2011 7:15 PM, "Romain Manni-Bu
so maybe an optionnal module (or otherwise we need to find a utility to it
;)...and to manage all hot deploy directory and hosts :p)
but why not an openejb-tool or openejb-helper for such features. I saw a
wiki generator, i didnt have a look why it was here but maybe it is another
example.
no?
On Nov 7, 2011, at 11:15 AM, Romain Manni-Bucau wrote:
> ok but the webappdeployer is not linked to the deployment at all, just to
> the way we deploy tcks so should we keep this ejb on trunk?
We'll also want to run it with the CDI TCK. Though that part we probably only
want to do in buildbot.
ok but the webappdeployer is not linked to the deployment at all, just to
the way we deploy tcks so should we keep this ejb on trunk?
- Romain
2011/11/7 David Blevins
>
> On Nov 6, 2011, at 4:22 PM, Jonathan Gallimore wrote:
>
> > My understanding - and this might be wrong - is that the existi
On Nov 6, 2011, at 4:22 PM, Jonathan Gallimore wrote:
> My understanding - and this might be wrong - is that the existing
> DeployerEjb behaves differently to just dropping the .war file in the
> webapps directory. When we deploy using DeployerEjb, OpenEJB processes the
> .war file first, and the
My understanding - and this might be wrong - is that the existing
DeployerEjb behaves differently to just dropping the .war file in the
webapps directory. When we deploy using DeployerEjb, OpenEJB processes the
.war file first, and then hands it off to Tomcat. Dropping the war in the
webapps folder
Hi,
Hmm, for jar and ear DeployerEjb should work (for war too but with some
tricky things abt classloadibg)...but shouldnt we manage hot deploy more
than this?
PS: i do not get why this deployer is useful, what is the goal? If i
understand it hopes tomcat already deployed the webapp, no?
- Romai
14 matches
Mail list logo
