Re: please commit patch for openejb-595 -- Thanks Karan!

2007-06-26 Thread David Blevins
Committed openejb-590-1.patch. Thanks Karan! -David On Jun 24, 2007, at 4:08 AM, Karan Malhi wrote: Mohammad, Sorry, Its my mistake. I attached the patch to openejb-590. You will find a file named openejb-590-1.patch. Please apply that patch. After the patch please close openejb-590 and ope

Re: please commit patch for openejb-595

2007-06-24 Thread Karan Malhi
Mohammad, Sorry, Its my mistake. I attached the patch to openejb-590. You will find a file named openejb-590-1.patch. Please apply that patch. After the patch please close openejb-590 and openejb-595 On 6/24/07, Mohammad Nour El-Din <[EMAIL PROTECTED]> wrote: It is my honor :-), but where is t

Re: please commit patch for openejb-595

2007-06-24 Thread Mohammad Nour El-Din
It is my honor :-), but where is the new patch to apply ??? On 6/21/07, Karan Malhi <[EMAIL PROTECTED]> wrote: Thats because you are running mvn from within the openejb-standalone module. From within the module we are running all phases of the lifecycle, however ff you run it from the root, it

Re: please commit patch for openejb-595

2007-06-21 Thread Karan Malhi
Thats because you are running mvn from within the openejb-standalone module. From within the module we are running all phases of the lifecycle, however ff you run it from the root, it should not work. This is because the assembly package phase is bound to the attached goal, which attaches it to a

Re: please commit patch for openejb-595

2007-06-21 Thread Mohammad Nour El-Din
The console output is attached, and BTW the shell script files are filtered and added to the distros without applying your latest change !!! On 6/21/07, Mohammad Nour El-Din <[EMAIL PROTECTED]> wrote: Sure, but now cauz I am preparing to go to work :-) On 6/21/07, Karan Malhi <[EMAIL PROTECTED

Re: please commit patch for openejb-595

2007-06-20 Thread Mohammad Nour El-Din
Sure, but now cauz I am preparing to go to work :-) On 6/21/07, Karan Malhi <[EMAIL PROTECTED]> wrote: Can you send me your maven console output? On 6/20/07, Karan Malhi <[EMAIL PROTECTED]> wrote: > I am not sure why it is not working for you. Its working fine for me, > I have tested it multip

Re: please commit patch for openejb-595

2007-06-20 Thread Karan Malhi
Can you send me your maven console output? On 6/20/07, Karan Malhi <[EMAIL PROTECTED]> wrote: I am not sure why it is not working for you. Its working fine for me, I have tested it multiple times On 6/20/07, Mohammad Nour El-Din <[EMAIL PROTECTED]> wrote: > Yeah I know that, but it didn't work

Re: please commit patch for openejb-595

2007-06-20 Thread Karan Malhi
I am not sure why it is not working for you. Its working fine for me, I have tested it multiple times On 6/20/07, Mohammad Nour El-Din <[EMAIL PROTECTED]> wrote: Yeah I know that, but it didn't work for me, I mean when you use the target/classes it is not included in the *.zip or *.tar.gz files

Re: please commit patch for openejb-595

2007-06-20 Thread Mohammad Nour El-Din
Yeah I know that, but it didn't work for me, I mean when you use the target/classes it is not included in the *.zip or *.tar.gz files ??? Any explanation for that ? On 6/20/07, Karan Malhi <[EMAIL PROTECTED]> wrote: Nice catch!! I have attached a new patch. I had to revert back to target/class

Re: please commit patch for openejb-595

2007-06-20 Thread Karan Malhi
Nice catch!! I have attached a new patch. I had to revert back to target/classes. Below is an explanation of why it has to be reverted back to target/classes. I will explain the various sections of the pom.xml in openejb-standalone module (see the comments before each plugin in the build element)

Re: please commit patch for openejb-595

2007-06-20 Thread Mohammad Nour El-Din
Well it worked by making the assembly plugin to look for files into the src/main/resources dir, I will commit that, but I will make the JIRA open and assigned to you for further comments, and when done we can close it. Thanks a lot Karan :-). On 6/20/07, Mohammad Nour El-Din <[EMAIL PROTECTED]> w

Re: please commit patch for openejb-595

2007-06-20 Thread Mohammad Nour El-Din
Done man, revision 549000 , filtering works, but there is something new happens, the openejb sheel script the only file I have in the /bin dir under the *.zip and *.tar.gz files. I guess it is something related to maven assembly plugin too, cauze in the bin.xml all files should be looked for in th

please commit patch for openejb-595

2007-06-18 Thread Karan Malhi
I have submitted a patch for the filtering issue in maven. created a new jira for this and attached the patch. Please test the patch and let me know if you face any issues. Suggestions welcome :) -- Karan Malhi