[jira] [Created] (OPENJPA-2811) Upgrade to ASM 8

2020-04-27 Thread Romain Manni-Bucau (Jira)
Romain Manni-Bucau created OPENJPA-2811: --- Summary: Upgrade to ASM 8 Key: OPENJPA-2811 URL: https://issues.apache.org/jira/browse/OPENJPA-2811 Project: OpenJPA Issue Type: Task

[jira] [Commented] (OPENJPA-2811) Upgrade to ASM 8

2020-04-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OPENJPA-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093594#comment-17093594 ] ASF subversion and git services commented on OPENJPA-2811: -- Co

[jira] [Resolved] (OPENJPA-2811) Upgrade to ASM 8

2020-04-27 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/OPENJPA-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved OPENJPA-2811. - Resolution: Fixed > Upgrade to ASM 8 > > > Key

Fwd: Build failed in Jenkins: OpenJPA-master #110

2020-04-27 Thread Francesco Chicchiriccò
Hi all, FYI, Jenkins keep failing (see attachments). Can someone check recent commits? Regards. --- Begin Message --- See Changes: [rmannibucau] OPENJPA-2811 asm8 support

Re: Build failed in Jenkins: OpenJPA-master #110

2020-04-27 Thread Romain Manni-Bucau
Hi Francesco, It requires https://repository.apache.org/content/repositories/orgapachegeronimo-1123 staging repo (I'm trying to prepare the coming release). Thought it was better to not add it then remove it from the pom but we can do it if you think it is worth it. Romain Manni-Bucau @rmannibuc

Re: Build failed in Jenkins: OpenJPA-master #110

2020-04-27 Thread Maxim Solodovnik
Can I merge my PR https://github.com/apache/openjpa/pull/59 ? On Mon, 27 Apr 2020 at 21:57, Romain Manni-Bucau wrote: > > Hi Francesco, > > It requires > https://repository.apache.org/content/repositories/orgapachegeronimo-1123 > staging repo (I'm trying to prepare the coming release). > Thought

Re: Build failed in Jenkins: OpenJPA-master #110

2020-04-27 Thread Romain Manni-Bucau
no objection from me (even if I'd still like a test ensuring the fix does something new and really fixes an issue ;)) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: Build failed in Jenkins: OpenJPA-master #110

2020-04-27 Thread Maxim Solodovnik
I'm not sure where this test should be added Can you point me to the good test for existing functionality, so I can extend it? On Mon, 27 Apr 2020 at 22:35, Romain Manni-Bucau wrote: > > no objection from me (even if I'd still like a test ensuring the fix does > something new and really fixes an

Re: Build failed in Jenkins: OpenJPA-master #110

2020-04-27 Thread Romain Manni-Bucau
Personally, I'd just extend SingleEMFTestCase , create a db state in plain jdbc and create a configured emf (needs to call createEntityManager() to actually call the ddl) and check the db grabbing a connection from DriverManager. side note: can be a good opportunity to reduce jpa 2.1 debt: https:/

Re: Build failed in Jenkins: OpenJPA-master #110

2020-04-27 Thread Maxim Solodovnik
Thanks! Will try to do in a day or two :) On Mon, 27 Apr 2020 at 23:08, Romain Manni-Bucau wrote: > > Personally, I'd just extend SingleEMFTestCase , create a db state in plain > jdbc and create a configured emf (needs to call createEntityManager() to > actually call the ddl) and check the db gra