[GitHub] [openjpa] eolivelli commented on pull request #66: Fix SelectImpl#getColumnAlias in case of DBDictionary that use delimiters aggressively

2020-07-15 Thread GitBox
eolivelli commented on pull request #66: URL: https://github.com/apache/openjpa/pull/66#issuecomment-658740170 @rmannibucau @struberg I am closing this PR, superseded by #67 This is an automated message from the Apache Git

[GitHub] [openjpa] eolivelli closed pull request #66: Fix SelectImpl#getColumnAlias in case of DBDictionary that use delimiters aggressively

2020-07-15 Thread GitBox
eolivelli closed pull request #66: URL: https://github.com/apache/openjpa/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Created] (OPENJPA-2818) DBDictionary > delimitIdentifiers = true does not work

2020-07-15 Thread Enrico Olivelli (Jira)
Enrico Olivelli created OPENJPA-2818: Summary: DBDictionary > delimitIdentifiers = true does not work Key: OPENJPA-2818 URL: https://issues.apache.org/jira/browse/OPENJPA-2818 Project: OpenJPA

[GitHub] [openjpa] rmannibucau commented on pull request #66: Fix SelectImpl#getColumnAlias in case of DBDictionary that use delimiters aggressively

2020-07-15 Thread GitBox
rmannibucau commented on pull request #66: URL: https://github.com/apache/openjpa/pull/66#issuecomment-658586585 This is what does the getColumnAlias in the enclosing class so it looks good to me, just requires to check all IT on all DB but I'm quite confident. ---