[GitHub] [openjpa] ilgrosso commented on pull request #69: OPENJPA-2818 DBDictionary > delimitIdentifiers = true does not work

2020-07-20 Thread GitBox
ilgrosso commented on pull request #69: URL: https://github.com/apache/openjpa/pull/69#issuecomment-661011182 whoever and does the merge, please do "squash & merge" :-) This is an automated message from the Apache Git Service

[GitHub] [openjpa] rmannibucau commented on pull request #69: OPENJPA-2818 DBDictionary > delimitIdentifiers = true does not work

2020-07-20 Thread GitBox
rmannibucau commented on pull request #69: URL: https://github.com/apache/openjpa/pull/69#issuecomment-661005910 Mergeable for me (i cant do it right now so if any dev with the perms agree and comes feel free to hit the green button) ---

[GitHub] [openjpa] eolivelli commented on pull request #69: OPENJPA-2818 DBDictionary > delimitIdentifiers = true does not work

2020-07-20 Thread GitBox
eolivelli commented on pull request #69: URL: https://github.com/apache/openjpa/pull/69#issuecomment-660941112 @rmannibucau let's see now github validation in action This is an automated message from the Apache Git Service.

[jira] [Resolved] (OPENJPA-2819) Add simple GitHub Actions validation for Pull Requests

2020-07-20 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/OPENJPA-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved OPENJPA-2819. - Resolution: Fixed Thanks a lot Enrico, merged! > Add simple GitHub Actions val

[GitHub] [openjpa] rmannibucau merged pull request #70: OPENJPA-2819 Add simple GitHub Actions validation for Pull Requests

2020-07-20 Thread GitBox
rmannibucau merged pull request #70: URL: https://github.com/apache/openjpa/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (OPENJPA-2819) Add simple GitHub Actions validation for Pull Requests

2020-07-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OPENJPA-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161108#comment-17161108 ] ASF subversion and git services commented on OPENJPA-2819: -- Co

[jira] [Commented] (OPENJPA-2819) Add simple GitHub Actions validation for Pull Requests

2020-07-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OPENJPA-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161109#comment-17161109 ] ASF subversion and git services commented on OPENJPA-2819: -- Co

[jira] [Commented] (OPENJPA-2819) Add simple GitHub Actions validation for Pull Requests

2020-07-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OPENJPA-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161107#comment-17161107 ] ASF subversion and git services commented on OPENJPA-2819: -- Co

[GitHub] [openjpa] rmannibucau commented on pull request #69: OPENJPA-2818 DBDictionary > delimitIdentifiers = true does not work

2020-07-20 Thread GitBox
rmannibucau commented on pull request #69: URL: https://github.com/apache/openjpa/pull/69#issuecomment-660928008 Once double allocation (https://github.com/apache/openjpa/pull/69/files#diff-59344a422210f668cbeb574dc22e8339R324) is fixed it can be merged for me ---