Re: enhance without Serp - Update

Thanks Mark, your last commit seems to have fixed, our build is green again. Nice job! Il lun 3 lug 2023, 18:10 Mark Struberg ha scritto: > Francesco, I've now pushed this change. Can you please try it out? Looks > good over here now. > Now I started the full Syncope build and hope all comes gr

Re: enhance without Serp - Update

Francesco, I've now pushed this change. Can you please try it out? Looks good over here now. Now I started the full Syncope build and hope all comes green again. txs and LieGrue, strub > Am 03.07.2023 um 17:55 schrieb Mark Struberg : > > Think I found the solution, but first want to run all tes

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739678#comment-17739678 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

Re: enhance without Serp - Update

Think I found the solution, but first want to run all tests in OpenJPA. I did use the standard ClassWriter in ASMHelper. This does use Class.forName. Changed ASMHelper to use the BCClassWriter you wrote some time ago. That should do the trick I hope. Gimme 10 minutes plz. LieGrue, strub > Am

Re: enhance without Serp - Update

@Francesco: can you *javap -v -cp $yourclasspath the.class.which.Fail* when it works vs when it fails please? Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: enhance without Serp - Update

Does not yet ring any bells, sorry :( Right now trying to fire up the enhancer manually in the debugger. Difference really is that we now do the ASM part way earlier, but still class per class. Before that it was done as part of the ASMAdapter. Still digging. LieGrue, strub > Am 03.07.2023 um

Re: enhance without Serp - Update

Or maybe the issue is just the enhancement order? In the JPARealm sample below, in fact, I can see that JPARealm.class is not yet enhanced so the error is raised while enhancing, and possibly because JPAAccountPolicy was not enhanced yet. On 03/07/23 17:00, Francesco Chicchiriccò wrote: Addin

Re: enhance without Serp - Update

Adding some info. First of all, the class to which the error message is referring is not always the same. Secondly, at least about AccountPolicy as reported below, the original error message is stating Execution enhancer of goal org.apache.openjpa:openjpa-maven-plugin:4.0.0-SNAPSHOT:enhance

Re: enhance without Serp - Update

On 03/07/23 16:27, Mark Struberg wrote: Went forward and compiled the Syncope main branch. Getting this error when running with mvn -X Caused by: java.lang.ClassNotFoundException: org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy at org.codehaus.plexus.classworlds.strate

Re: enhance without Serp - Update

Went forward and compiled the Syncope main branch. Getting this error when running with mvn -X Caused by: java.lang.ClassNotFoundException: org.apache.syncope.core.persistence.api.entity.policy.AccountPolicy at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass (SelfFirstS

Re: enhance without Serp - Update

Hi Francesco! Can you see which one of the classes fail to enhance? In which case you might try to run the enhancement of that very class manually in your IDE. Main class: org.apache.openjpa.enhance.PCEnhancer VMOptions:: -ea -Dopenjpa.ConnectionURL=jdbc:derby:target/database/openjpa-derby-dat

Re: enhance without Serp - Update

Hi Mark, thanks for your reply. So I am proceeding as follows. Took the executions at https://ci-builds.apache.org/job/OpenJPA/job/OpenJPA-master-deploy/ (the Jenkins job which is publishing SNAPSHOT artifacts from master to ASF Maven repo) and saw that the artifacts with which the Syncope bu

Re: enhance without Serp - Update

Hi Francesco! That's very valuable information! Could you please do a git-bisect to find out which change did break it? Actually the algorithm to select which classes are to be enhanced should not have changed. Thus I'm really curious what I did break. Most times the amount of enhanced classes

Re: enhance without Serp - Update

From a very preliminary analysis it seems that just a subset of the persistence-capable classes are effectively found and enhanced: now [2], it used to be [3]. I'll continue investigating. Regards. On 03/07/23 13:56, Francesco Chicchiriccò wrote: Hi Mark, the build on Syncope master branch,

Re: enhance without Serp - Update

Hi Mark, the build on Syncope master branch, using OpenJPA 4.0.0-SNAPSHOT is now failing - it used to work at least until last June 30th. The issues seem to be related to entity enhancement, which we perform via openjpa-maven-plugin - see [1]. Is there anything obvious we should be changing? M

Re: enhance without Serp - Update

Update: I've now merged the wip to our master and pushed it to the ASF gitox repo. I think we already came pretty far and it looks really promising. So there is a high chance that we succeed, although there is still plenty of work in front of us. How it works: Basically there are 2 sets of i

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739544#comment-17739544 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739548#comment-17739548 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739554#comment-17739554 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739549#comment-17739549 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739551#comment-17739551 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739552#comment-17739552 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739559#comment-17739559 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739562#comment-17739562 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739560#comment-17739560 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739561#comment-17739561 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739539#comment-17739539 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739542#comment-17739542 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739553#comment-17739553 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739547#comment-17739547 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739555#comment-17739555 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739550#comment-17739550 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739557#comment-17739557 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739558#comment-17739558 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739556#comment-17739556 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739546#comment-17739546 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739541#comment-17739541 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739545#comment-17739545 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739543#comment-17739543 ] ASF subversion and git services commented on OPENJPA-2911: -- Co

[jira] [Commented] (OPENJPA-2911) Replace Serp with native ASM code

[ https://issues.apache.org/jira/browse/OPENJPA-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739540#comment-17739540 ] ASF subversion and git services commented on OPENJPA-2911: -- Co