Re: Need process help for a code change that does not have an openJPA testcase.

o so. > >> > >> Regards, > >> Ravi. > >> > >> -Original Message- > >> From: Michael Dick [mailto:michael.d.d...@gmail.com] > >> Sent: Wednesday, December 02, 2009 8:48 AM > >> To: dev@openjpa.apache.org > >> Sub

Re: Need process help for a code change that does not have an openJPA testcase.

really help me out later if we have comments indicating why >> this list isn't genericized >> Sorry, I did not added any comments to my patch. >> Will do so. >> >> Regards, >> Ravi. >> >> -Original Message- >> From: Michael Dick [m

Re: Need process help for a code change that does not have an openJPA testcase.

- >> From: Michael Dick [mailto:michael.d.d...@gmail.com] >> Sent: Wednesday, December 02, 2009 8:48 AM >> To: dev@openjpa.apache.org >> Subject: Re: Need process help for a code change that does not have an >> openJPA testcase. >> >> I was thinking of addi

Re: Need process help for a code change that does not have an openJPA testcase.

sn't genericized > Sorry, I did not added any comments to my patch. > Will do so. > > Regards, > Ravi. > > -Original Message- > From: Michael Dick [mailto:michael.d.d...@gmail.com] > Sent: Wednesday, December 02, 2009 8:48 AM > To: dev@openjpa.apache.org &g

RE: Need process help for a code change that does not have an openJPA testcase.

@gmail.com] Sent: Wednesday, December 02, 2009 8:48 AM To: dev@openjpa.apache.org Subject: Re: Need process help for a code change that does not have an openJPA testcase. I was thinking of adding a new interface that OpenJPAId would implement and then the Kodo wrapper (which appears to only

Re: Need process help for a code change that does not have an openJPA testcase.

I was thinking of adding a new interface that OpenJPAId would implement and then the Kodo wrapper (which appears to only exist in my mind) could also implement that. Since there is no Kodo equivalent of OpenJPAId or ObjectId it would be a major change for Kodo and I'm not terribly inclined to do t

Re: Need process help for a code change that does not have an openJPA testcase.

Mike, Also regarding "In trunk it might be better to define an interface that kodo can extend rather than just removing the cast." In openJPA; OpenJPAId is an abstract class and ObjectId extends OpenJPAId. The casting expects the object returned to be castable to OpenJPAId. So I think providin

Re: Need process help for a code change that does not have an openJPA testcase.

Hi Mike, In kodo application id will not be wrapped in any sort of objectId. The applicationId object will directly be returned. E.g: In OpenJPA, public Object pcNewObjectIdInstance() { return new ObjectId(org.apache.openjpa.persistence.jdbc.meta.RaviA.class, new RaviAId()); } In Kodo, pub

Re: Need process help for a code change that does not have an openJPA testcase.

Just a couple of thoughts.. Presumably Kodo uses a product derivation that causes a different ObjectId . If that's the case we probably could introduce a test derivation that does something similar and verifies the fix. That said, removing the cast shouldn't be impossible to do. In trunk it might

Re: Need process help for a code change that does not have an openJPA testcase.

Yep, go ahead and open a JIRA and include the details from your email, along with which OpenJPA releases this needs to be addressed in. -Donald Ravi P Palacherla wrote: Hi All, As part of OPENJPA-263 the following code is added to org/apache/openjpa/datacache/DataCacheStoreManager.java