Re: KStreamManager and IKStreamManager

I understand the motivation for the 2 lists. But you could even have 2 lists but in ONE class. This should be abstracted into one place, that has a defined API to access the KStream. So that no consumer comes up with the idea to bypass the methods to directly access a KStream. Other then the

[GitHub] [openmeetings] solomax commented on issue #55: [OPENMEETINGS-2314] Fix the video screens in grid structure!

solomax commented on issue #55: URL: https://github.com/apache/openmeetings/issues/55#issuecomment-620112597 Should be fixed This is an automated message from the Apache Git Service. To respond to the message, please log on

Jenkins build is back to normal : openmeetings #3157

See

Jenkins build is back to normal : openmeetings » Openmeetings Core #3157

See

[GitHub] [openmeetings] solomax commented on pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

solomax commented on pull request #69: URL: https://github.com/apache/openmeetings/pull/69#issuecomment-619912195 On Mon, 27 Apr 2020 at 18:08, Sebastian Wagner wrote: > I know but still I don't think there is any real alternative in the Java > world. > > It's also quite

[GitHub] [openmeetings] sebawagner commented on pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

sebawagner commented on pull request #69: URL: https://github.com/apache/openmeetings/pull/69#issuecomment-619910830 I know but still I don't think there is any real alternative in the Java world. It's also quite a difficult task: Write a code that understand a code language

[GitHub] [openmeetings] solomax commented on pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

solomax commented on pull request #69: URL: https://github.com/apache/openmeetings/pull/69#issuecomment-619874905 @sebawagner "Trailing space" checker is outside `TreeWalker` and it doesn't work with files other than `*.java` One of the most weird plugin I ever use

Re: How long until we break away the conference room JavaScript from the rest of the Wicket application :)

Hello Sebastian, I haven't planned to "brea away the conference room" and re-writing anything My goals were to 1) simplify JS dependency management 2) simplify Maven build 3) clean-up "manual polyfilling" and some hacks 4) use latest MathJax https://github.com/mathjax/MathJax/issues/2414 5*)

[GitHub] [openmeetings] JosekuttyMJ commented on issue #70: hello ,looking for urgent help

JosekuttyMJ commented on issue #70: URL: https://github.com/apache/openmeetings/issues/70#issuecomment-619862244 Tested with Opera,chrome and firefox This is an automated message from the Apache Git Service. To respond to

[GitHub] [openmeetings] JosekuttyMJ opened a new issue #70: hello ,looking for urgent help

JosekuttyMJ opened a new issue #70: URL: https://github.com/apache/openmeetings/issues/70 i have installed OM 5 m5 in AWS ubuntu 18.04 along with kurento and mysql .everything working fine except when start a new conference i can see my camera working also for the joined user as his

Re: KStreamManager and IKStreamManager

Hello Sebastian, If I do remember correctly `StreamProcessor::streamByUid ` was created to speed-up stream search (to avoid iterating all KRooms) The main source-of-truth should be KRoom Duplication is bad thing - no doubt but I thought extra-iterating is worst :) I tried to make both consistent

How long until we break away the conference room JavaScript from the rest of the Wicket application :)

Hi, how about we start to plan how to break away the conference room from the rest of the application ? It is already a lot of pure JavaScript. And writing it would be probably easier. As well as you constantly need latest JS features. Compile it stand-alone with Npm or yarn. use a package.json

Build failed in Jenkins: openmeetings #3156

See Changes: [sebawagner] OPENMEETINGS-2307 Add checkstyle check with only checking for unused [solomax666] [OPENMEETINGS-2307] checkstyle rules are specified inline, additional

Build failed in Jenkins: openmeetings » Openmeetings Core #3156

See Changes: [sebawagner] OPENMEETINGS-2307 Add checkstyle check with only checking for unused [solomax666] [OPENMEETINGS-2307] checkstyle rules are specified inline,

[GitHub] [openmeetings] sebawagner commented on pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

sebawagner commented on pull request #69: URL: https://github.com/apache/openmeetings/pull/69#issuecomment-619790357 I can't "approve" my own pull request :) This is an automated message from the Apache Git Service. To

[GitHub] [openmeetings] sebawagner commented on a change in pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

sebawagner commented on a change in pull request #69: URL: https://github.com/apache/openmeetings/pull/69#discussion_r415515187 ## File path: pom.xml ## @@ -1084,6 +1122,22 @@ +