[GitHub] [openmeetings] sebawagner commented on pull request #159: OPENMEETINGS-2678 Update and ignore if Notificaiton API is not available

2021-10-06 Thread GitBox
sebawagner commented on pull request #159: URL: https://github.com/apache/openmeetings/pull/159#issuecomment-937176725 > @sebawagner I'll update some dependencies in master Could you please cherry-pick these changes? :))) Cherry pick, why? I can just merge master to the 6-2 branch

[GitHub] [openmeetings] sebawagner merged pull request #159: OPENMEETINGS-2678 Update and ignore if Notificaiton API is not available

2021-10-06 Thread GitBox
sebawagner merged pull request #159: URL: https://github.com/apache/openmeetings/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [openmeetings] sebawagner commented on a change in pull request #159: OPENMEETINGS-2678 Update and ignore if Notificaiton API is not available

2021-10-06 Thread GitBox
sebawagner commented on a change in pull request #159: URL: https://github.com/apache/openmeetings/pull/159#discussion_r723688323 ## File path: openmeetings-web/src/main/front/main/src/omutils.js ## @@ -63,12 +65,16 @@ function _requestNotifyPermission(callback, elseCallback)

[CANCELED] [VOTE] Apache OpenMeetings 6.2.0 based on Release Candidate 2

2021-10-06 Thread Maxim Solodovnik
due to a critical bug found get ready for rc3 :) On Mon, 4 Oct 2021 at 04:25, seba.wag...@gmail.com wrote: > This vote has passed as successful. > > However we discovered some issues on iOS/Mobile. The issue is that on > Mobile Safari/iOS and Chrome/iOS (probably any iOS mobile browser) you >

[GitHub] [openmeetings] solomax closed issue #158: Can be multiple personal screen recording

2021-10-06 Thread GitBox
solomax closed issue #158: URL: https://github.com/apache/openmeetings/issues/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [openmeetings] solomax commented on issue #158: Can be multiple personal screen recording

2021-10-06 Thread GitBox
solomax commented on issue #158: URL: https://github.com/apache/openmeetings/issues/158#issuecomment-936598676 Hello @lizige, Only one person in the room can do recording -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [openmeetings] solomax commented on pull request #159: OPENMEETINGS-2678 Update and ignore if Notificaiton API is not available

2021-10-06 Thread GitBox
solomax commented on pull request #159: URL: https://github.com/apache/openmeetings/pull/159#issuecomment-936500946 One more NOTE: could you please change `typeof Notification` to be `typeof(Notification)` ? (for consistency :))) -- This is an automated message from the Apache Git

[GitHub] [openmeetings] solomax commented on pull request #159: OPENMEETINGS-2678 Update and ignore if Notificaiton API is not available

2021-10-06 Thread GitBox
solomax commented on pull request #159: URL: https://github.com/apache/openmeetings/pull/159#issuecomment-936489073 @sebawagner I'll update some dependencies in master Could you please cherry-pick these changes? :))) -- This is an automated message from the Apache Git Service. To

[GitHub] [openmeetings] solomax commented on a change in pull request #159: OPENMEETINGS-2678 Update and ignore if Notificaiton API is not available

2021-10-06 Thread GitBox
solomax commented on a change in pull request #159: URL: https://github.com/apache/openmeetings/pull/159#discussion_r723390169 ## File path: openmeetings-web/src/main/front/main/src/omutils.js ## @@ -63,12 +65,16 @@ function _requestNotifyPermission(callback, elseCallback) {