[GitHub] [openmeetings] sebawagner commented on pull request #65: OPENMEETINGS-2278 fix restart of recording and ghost KStream

2020-04-24 Thread GitBox
sebawagner commented on pull request #65: URL: https://github.com/apache/openmeetings/pull/65#issuecomment-618852104 @solomax it works now! You can enable the recoridng and it will just start recoring, you can stop it and it will stop recording and only stop sharing if sharing was di

[GitHub] [openmeetings] sebawagner commented on pull request #65: OPENMEETINGS-2278 fix restart of recording and ghost KStream

2020-04-24 Thread GitBox
sebawagner commented on pull request #65: URL: https://github.com/apache/openmeetings/pull/65#issuecomment-618853159 > I would say `If stopping the recording it will also stop the sharing of the screen` is not the best option => That is fixed now. It won't stop the sharing - except - sha

[GitHub] [openmeetings] sebawagner commented on pull request #65: OPENMEETINGS-2278 fix restart of recording and ghost KStream

2020-04-24 Thread GitBox
sebawagner commented on pull request #65: URL: https://github.com/apache/openmeetings/pull/65#issuecomment-619210249 @solomax r u happy with it? I can't find or think of any regression introduced by it This is an automated m

[GitHub] [openmeetings] sebawagner commented on pull request #65: OPENMEETINGS-2278 fix restart of recording and ghost KStream

2020-04-24 Thread GitBox
sebawagner commented on pull request #65: URL: https://github.com/apache/openmeetings/pull/65#issuecomment-619240155 Please let me know on the approach. There is really not much that changed. I should simply now work as expected. If you're happy with the PR, I start thinking of mo

[GitHub] [openmeetings] sebawagner commented on pull request #65: OPENMEETINGS-2278 fix restart of recording and ghost KStream

2020-04-24 Thread GitBox
sebawagner commented on pull request #65: URL: https://github.com/apache/openmeetings/pull/65#issuecomment-619251117 Thanks! Take care! This is an automated message from the Apache Git Service. To respond to the message, plea