solomax commented on a change in pull request #159:
URL: https://github.com/apache/openmeetings/pull/159#discussion_r723390169
##########
File path: openmeetings-web/src/main/front/main/src/omutils.js
##########
@@ -63,12 +65,16 @@ function _requestNotifyPermission(callback, elseCallback) {
} else {
Notification.requestPermission().then(onRequest);
}
- } else if (typeof(elseCallback) === 'function') {
- elseCallback();
+ } else {
+ _info("No notification API for this browser");
Review comment:
This code block is being repeated :(
But I guess refactoring can wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
