[GitHub] [openmeetings] solomax commented on pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

2020-04-27 Thread GitBox
solomax commented on pull request #69: URL: https://github.com/apache/openmeetings/pull/69#issuecomment-619912195 On Mon, 27 Apr 2020 at 18:08, Sebastian Wagner wrote: > I know but still I don't think there is any real alternative in the Java > world. > > It's also quite

[GitHub] [openmeetings] solomax commented on pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

2020-04-27 Thread GitBox
solomax commented on pull request #69: URL: https://github.com/apache/openmeetings/pull/69#issuecomment-619874905 @sebawagner "Trailing space" checker is outside `TreeWalker` and it doesn't work with files other than `*.java` One of the most weird plugin I ever use ---

[GitHub] [openmeetings] solomax commented on pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

2020-04-26 Thread GitBox
solomax commented on pull request #69: URL: https://github.com/apache/openmeetings/pull/69#issuecomment-619705692 I have added some changes @sebawagner please review As I wrote before I found no way to add checks for non-java files this plugin - is something non-configurable ---

[GitHub] [openmeetings] solomax commented on pull request #69: OPENMEETINGS-2307 Add checkstyle check with simplistic checks

2020-04-26 Thread GitBox
solomax commented on pull request #69: URL: https://github.com/apache/openmeetings/pull/69#issuecomment-619703611 Hello @sebawagner, I, personally, don't like check-style plugin :( According to my experience it is near to impossible to be configured in non-default way Already s