Re: [IMPORTANT] GSOC 2013

2013-05-21 Thread Maxim Solodovnik
Hello Andun, is not necessary (it is embedded into Wicket, maybe some standard check should be performed) here is the Behavior you can take a look at: https://github.com/sebfz1/wicket-jquery-ui/blob/master/wicket-jquery-ui-core/src/main/java/com/googlecode/wicket/jquery/core/JQueryBehavior.java

Re: [IMPORTANT] GSOC 2013

2013-05-22 Thread Andun Sameera
OK Maxim. Until then I will work based on the article which describes to add a javascript ibraya as a wicket component in here https://cwiki.apache.org/WICKET/creating-a-behavior-to-use-a-javascript-library.html. Thanks! On Wed, May 22, 2013 at 9:31 AM, Maxim Solodovnik wrote: > Hello Andun, >

Re: [IMPORTANT] GSOC 2013

2013-05-23 Thread Andun Sameera
Hi Maxim, I have successfully created the initial version of the EmotIcon Wicket Module in https://github.com/andunslg/EmotIcons-Wicket. I have created the module in the following way, We can add the behavior like this, EmotIconsBehavior emotIconsBehavior=new EmotIconsBehavior(); this.add(emotIc

Re: [IMPORTANT] GSOC 2013

2013-05-23 Thread Maxim Solodovnik
Hello Andun, Thanks for the plugin I have asked Sebastian regarding including plugin into wicket-jquery-ui [1] if plugin will be accepted the code required will be reduced a lot: [2] Here is my review: 1) currently code at https://github.com/andunslg/EmotIcons-Wicket contains both behavior and ex

Re: [IMPORTANT] GSOC 2013

2013-05-24 Thread Andun Sameera
Hi Maxim, Thank you very much for the review. Until Sebastian gives the response. I will develop this plug-in. That will make the effort further easy to create in in wicket-jquery-ui. On Fri, May 24, 2013 at 12:07 PM, Maxim Solodovnik wrote: > Hello Andun, > > Thanks for the plugin > I have aske

Re: [IMPORTANT] GSOC 2013

2013-05-24 Thread Andun Sameera
Hi Maxim, I have updated the module and sample with new methods to do emtoiconizing and unemoticonizing. With new change we can do, emotIconsBehavior.addEmoticonize(".class"); emotIconsBehavior.addUnemoticonize(".class2"); emotIconsBehavior.addUnemoticonize("#id2"); emotIconsBehavior.addEmoticoni

Re: [IMPORTANT] GSOC 2013

2013-05-25 Thread Maxim Solodovnik
Sebastian has answered could you please check his instructions? I'll review you code most probably tomorrow On Sat, May 25, 2013 at 1:05 AM, Andun Sameera wrote: > Hi Maxim, > > I have updated the module and sample with new methods to do emtoiconizing > and unemoticonizing. With new change we

Re: [IMPORTANT] GSOC 2013

2013-05-25 Thread Andun Sameera
Hi Maxim, I have gone through the guide provided by Sebastian. I have done those steps in my implementation with long steps. With this method we can reduce those steps pretty easily. I will change my code according to those steps. Also I will keep the plug-in in the same repo which I have created.

Re: [IMPORTANT] GSOC 2013

2013-05-25 Thread Maxim Solodovnik
please also change the package and I don't really like the method names ... emotIconsBehavior.addEmoticonize emotIconsBehavior.addUnemoticonize looks too big I would propose to "addEmoticonize" on behavior add like mydiv.add(new EmotIconsBehavior("#myDiv")); //will add Emoticonize mydiv.add(new Em