[GitHub] opennlp pull request #41: OPENNLP-920: Enforce TypeSafety in SequenceTrainer

2017-01-09 Thread smarthi
GitHub user smarthi opened a pull request: https://github.com/apache/opennlp/pull/41 OPENNLP-920: Enforce TypeSafety in SequenceTrainer You can merge this pull request into a Git repository by running: $ git pull https://github.com/smarthi/opennlp OPENNLP-920 Alternatively

[GitHub] opennlp pull request #40: OPENNLP:-83 Add equals to AbstractModels and refer...

2017-01-09 Thread kottmann
GitHub user kottmann opened a pull request: https://github.com/apache/opennlp/pull/40 OPENNLP:-83 Add equals to AbstractModels and referenced classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/kottmann/opennlp OPENNLP-83

Re: Commit message style

2017-01-09 Thread William Colen
+1 for the OPENNLP-xxx: commit message. Fast to find a commit. 2017-01-09 21:24 GMT-02:00 Joern Kottmann : > On Mon, 2017-01-09 at 17:02 -0500, Jeffrey Zemerick wrote: > > I'm personally a fan of the issue number being the first thing on the > > subject line, like

[GitHub] opennlp pull request #39: Remove deprecated IndexHashTable class

2017-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/opennlp/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Commit message style

2017-01-09 Thread Suneel Marthi
On Mon, Jan 9, 2017 at 5:02 PM, Jeffrey Zemerick wrote: > I'm personally a fan of the issue number being the first thing on the > subject line, like "OPENNLP-xxx: commit message." For me it gives a > consistent place to look for the issue without having to read the full >

Re: Trunk vs. Master

2017-01-09 Thread Joern Kottmann
Sorry for the confusion, this should have been done differently when we moved from svn to git. The other repositories opennlp-addons.git and opennlp-sandbox.git only have the master branch. Jörn On Mon, 2017-01-09 at 13:21 -0500, Suneel Marthi wrote: > ITs the 'master' going forward, we'll be

Re: Commit message style

2017-01-09 Thread Joern Kottmann
It doesn't matter where the jira# is placed, as long as it is there. Can be in the first line or occur somewhere later in the message, for example see OPENNLP-914. There it was placed in the body. Jörn On Mon, 2017-01-09 at 13:20 -0500, Suneel Marthi wrote: > I guess the reason to include the

Re: Trunk vs. Master

2017-01-09 Thread Suneel Marthi
ITs the 'master' going forward, we'll be filing an infra request to delete the 'trunk' branch. On Mon, Jan 9, 2017 at 1:18 PM, Russ, Daniel (NIH/CIT) [E] < dr...@mail.nih.gov> wrote: > Hello, >I am a little confused by the fact we have both a trunk and a master > branch. Which branch should

Trunk vs. Master

2017-01-09 Thread Russ, Daniel (NIH/CIT) [E]
Hello, I am a little confused by the fact we have both a trunk and a master branch. Which branch should be the baseline? Can we remove the other? Daniel Daniel Russ, Ph.D. Staff Scientist, Office of Intramural Research Center for Information Technology National Institutes of Health U.S.

Commit message style

2017-01-09 Thread Joern Kottmann
Hello all, we are using different styles for commit messages. It would be good to have a short discussion on how we think they should be and agree all on how to write the subject line. Here are few points from me: - Good commit messages are important to understand what happened in the project

[GitHub] opennlp pull request #34: OPENNLP-719: Restore “type” argument in NameFi...

2017-01-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/opennlp/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Release Process on wiki

2017-01-09 Thread Rodrigo Agerri
great! R On Thu, Jan 5, 2017 at 8:12 PM, Chris Mattmann wrote: > Hi, > > Thanks to the team, we now have a release process on the wiki. > > https://cwiki.apache.org/confluence/display/OPENNLP/Release+Process > > @Community > > Please check it out and you can follow on for