There is a block in BaseModel.java that checks to see if the model's major
version number matches OpenNLP's major version number. Running this with an
OpenNLP 2.0.0 version causes the check to fail (2 != 1).
I have made a pull request [1] to change that check to just make sure the
major version nu
jzonthemtn commented on code in PR #415:
URL: https://github.com/apache/opennlp/pull/415#discussion_r854176140
##
opennlp-tools/src/main/java/opennlp/tools/util/model/BaseModel.java:
##
@@ -416,10 +416,8 @@ protected void validateArtifactMap() throws
InvalidFormatException {
jzonthemtn commented on code in PR #415:
URL: https://github.com/apache/opennlp/pull/415#discussion_r854176140
##
opennlp-tools/src/main/java/opennlp/tools/util/model/BaseModel.java:
##
@@ -416,10 +416,8 @@ protected void validateArtifactMap() throws
InvalidFormatException {
jzonthemtn opened a new pull request, #415:
URL: https://github.com/apache/opennlp/pull/415
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
-
jzonthemtn opened a new pull request, #414:
URL: https://github.com/apache/opennlp/pull/414
These tests were moved to *IT.java files but not removed from the *Test.java
files. They don't need to run during a regular build.
---
Thank you for contributing to Apache OpenNLP.
