[GitHub] [opennlp] rzo1 merged pull request #463: OPENNLP-1420 - Bump uimaj-core from 3.1.1 to 3.3.1 in /opennlp-uima

rzo1 merged PR #463: URL: https://github.com/apache/opennlp/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

[GitHub] [opennlp] rzo1 commented on a diff in pull request #461: OPENNLP-1416 Enhance JavaDoc in opennlp.tools.formats.ad package

rzo1 commented on code in PR #461: URL: https://github.com/apache/opennlp/pull/461#discussion_r1052995489 ## opennlp-tools/src/main/java/opennlp/tools/formats/ad/ADNameSampleStream.java: ## @@ -154,61 +153,49 @@ public class ADNameSampleStream implements ObjectStream { pri

[GitHub] [opennlp] rzo1 merged pull request #464: OPENNLP-1363 : Documentation update from lemmatizer split by tabs and not spaces.

rzo1 merged PR #464: URL: https://github.com/apache/opennlp/pull/464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

[GitHub] [opennlp] mawiesne commented on pull request #459: OPENNLP-1413 Enhance JavaDoc in opennlp.tools.util package

mawiesne commented on PR #459: URL: https://github.com/apache/opennlp/pull/459#issuecomment-1358912696 Thanks for your feedback, Bruno! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [opennlp] mawiesne commented on a diff in pull request #459: OPENNLP-1413 Enhance JavaDoc in opennlp.tools.util package

mawiesne commented on code in PR #459: URL: https://github.com/apache/opennlp/pull/459#discussion_r1052961165 ## opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java: ## @@ -144,29 +158,20 @@ public static BaseModel downloadModel(URL url, Class type) throws IOExcept

[GitHub] [opennlp] mawiesne commented on a diff in pull request #459: OPENNLP-1413 Enhance JavaDoc in opennlp.tools.util package

mawiesne commented on code in PR #459: URL: https://github.com/apache/opennlp/pull/459#discussion_r1052960333 ## opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java: ## @@ -50,68 +45,81 @@ public enum ModelType { CHUNKER("chunker"), PARSER("parser-chunking

[GitHub] [opennlp] kinow commented on a diff in pull request #459: OPENNLP-1413 Enhance JavaDoc in opennlp.tools.util package

kinow commented on code in PR #459: URL: https://github.com/apache/opennlp/pull/459#discussion_r1052679956 ## opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java: ## @@ -50,68 +45,81 @@ public enum ModelType { CHUNKER("chunker"), PARSER("parser-chunking");

[GitHub] [opennlp] kinow commented on a diff in pull request #461: OPENNLP-1416 Enhance JavaDoc in opennlp.tools.formats.ad package

kinow commented on code in PR #461: URL: https://github.com/apache/opennlp/pull/461#discussion_r1052672784 ## opennlp-tools/src/main/java/opennlp/tools/formats/ad/ADChunkSampleStreamFactory.java: ## @@ -36,7 +36,8 @@ * A Factory to create a Arvores Deitadas ChunkStream from th

[GitHub] [opennlp] mawiesne opened a new pull request, #465: OPENNLP-1419 Enhance Tests and JavaDoc in opennlp.morfologik package

mawiesne opened a new pull request, #465: URL: https://github.com/apache/opennlp/pull/465 Change - - renames some unit test classes to match the class names under test - introduces common base test class `AbstractMorfologikTest` to reduce dependencies among test classes - extract

Re: Logging in OpenNLP

Thanks for bringing this to the mailing list, Richard. I think your findings from digging into the history are accurate. Of your given options, which seem comprehensive, I think my preference is option D, followed by C, but I'm very interested in what others think. With option D, if we implement

Re: Renaming of master branch to main

The renaming operation itself requires a INFRA ticket via a PMC member. Afterwards it is rather easy to adjust the CI / website things. I can do that. Gruß Richard Am Montag, dem 19.12.2022 um 14:34 -0500 schrieb Jeff Zemerick: > I don't think this requires a vote. If anyone disagrees please say

Re: Renaming of master branch to main

I don't think this requires a vote. If anyone disagrees please say so. I wrote https://issues.apache.org/jira/browse/OPENNLP-1418 to capture this. If anyone has some free cycles please feel free to take it. If not, I'll try to get it over the coming holidays. Thanks, Jeff On Thu, Dec 15, 2022 at

[GitHub] [opennlp] mawiesne commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

mawiesne commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052564888 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } +

[GitHub] [opennlp] rzo1 commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

rzo1 commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052554362 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } + /**

[GitHub] [opennlp] rzo1 commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

rzo1 commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052554159 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } + /**

[GitHub] [opennlp] jzonthemtn commented on pull request #464: OPENNLP-1363 : Documentation update from lemmatizer split by tabs and not spaces.

jzonthemtn commented on PR #464: URL: https://github.com/apache/opennlp/pull/464#issuecomment-1357759446 Thanks @atarora! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [opennlp] mawiesne commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

mawiesne commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052254776 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } +

[GitHub] [opennlp] mawiesne commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

mawiesne commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052254418 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } +

[GitHub] [opennlp] kinow commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

kinow commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052237462 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } + /*

[GitHub] [opennlp] kinow commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

kinow commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052237129 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } + /*

[GitHub] [opennlp] atarora opened a new pull request, #464: OPENNLP-1363 : Documentation update from lemmatizer split by tabs and not spaces.

atarora opened a new pull request, #464: URL: https://github.com/apache/opennlp/pull/464 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x]

[GitHub] [opennlp] mawiesne commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

mawiesne commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052226452 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } +

[GitHub] [opennlp] mawiesne commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

mawiesne commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052225879 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } +

[GitHub] [opennlp] mawiesne commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

mawiesne commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052221134 ## opennlp-tools/src/main/java/opennlp/tools/namefind/TokenNameFinderModel.java: ## @@ -88,37 +117,109 @@ public TokenNameFinderModel(String languageCode, MaxentModel n

[GitHub] [opennlp] mawiesne commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

mawiesne commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052218809 ## opennlp-tools/src/main/java/opennlp/tools/namefind/NameFinderEventStream.java: ## @@ -32,36 +32,38 @@ import opennlp.tools.util.featuregen.WindowFeatureGenerator;

[GitHub] [opennlp] mawiesne commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

mawiesne commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052216345 ## opennlp-tools/src/main/java/opennlp/tools/namefind/TokenNameFinderModel.java: ## @@ -88,37 +117,109 @@ public TokenNameFinderModel(String languageCode, MaxentModel n

[GitHub] [opennlp] atarora commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

atarora commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052160001 ## opennlp-tools/src/main/java/opennlp/tools/namefind/TokenNameFinderModel.java: ## @@ -88,37 +117,109 @@ public TokenNameFinderModel(String languageCode, MaxentModel na

[GitHub] [opennlp] atarora commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

atarora commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052157920 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } +

[GitHub] [opennlp] atarora commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

atarora commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052153428 ## opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java: ## @@ -178,18 +197,34 @@ public void clearAdaptiveData() { // nothing to clear } +

[GitHub] [opennlp] kinow commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

kinow commented on code in PR #456: URL: https://github.com/apache/opennlp/pull/456#discussion_r1052046193 ## opennlp-tools/src/main/java/opennlp/tools/namefind/NameFinderEventStream.java: ## @@ -32,36 +32,38 @@ import opennlp.tools.util.featuregen.WindowFeatureGenerator; /*

[GitHub] [opennlp] kinow commented on a diff in pull request #459: OPENNLP-1413 Enhance JavaDoc in opennlp.tools.util package

kinow commented on code in PR #459: URL: https://github.com/apache/opennlp/pull/459#discussion_r1052035017 ## opennlp-tools/src/main/java/opennlp/tools/util/ext/ExtensionLoader.java: ## @@ -41,20 +42,23 @@ static void setOSGiAvailable() { // Pass in the type (interface) of

[GitHub] [opennlp] mawiesne commented on a diff in pull request #459: OPENNLP-1413 Enhance JavaDoc in opennlp.tools.util package

mawiesne commented on code in PR #459: URL: https://github.com/apache/opennlp/pull/459#discussion_r1051953520 ## opennlp-tools/src/main/java/opennlp/tools/util/ext/ExtensionLoader.java: ## @@ -41,20 +42,23 @@ static void setOSGiAvailable() { // Pass in the type (interface)

[GitHub] [opennlp] dependabot[bot] opened a new pull request, #463: Bump uimaj-core from 3.1.1 to 3.3.1 in /opennlp-uima

dependabot[bot] opened a new pull request, #463: URL: https://github.com/apache/opennlp/pull/463 Bumps [uimaj-core](https://github.com/apache/uima-uimaj) from 3.1.1 to 3.3.1. Release notes Sourced from https://github.com/apache/uima-uimaj/releases";>uimaj-core's releases. Ap

[GitHub] [opennlp] mawiesne merged pull request #458: OPENNLP-1412 Provide equals and hashCode for ParserModel and TokenizerModel

mawiesne merged PR #458: URL: https://github.com/apache/opennlp/pull/458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.