[GitHub] [opennlp-sandbox] mawiesne commented on pull request #76: Update sandbox component 'summarizer' to be compatible with latest opennlp-tools release

mawiesne commented on PR #76: URL: https://github.com/apache/opennlp-sandbox/pull/76#issuecomment-1419595087 @rzo1 I provided some cosmetics - ready to proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[VOTE] Apache OpenNLP 2.1.1 Release Candidate 2

Hi folks, I have posted a 2nd release candidate for the Apache OpenNLP 2.1.1 release and it is ready for testing. The distributables can be downloaded from: https://repository.apache.org/content/repositories/orgapacheopennlp-1032/org/apache/opennlp/opennlp-distr/2.1.1/ The release was made from

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #76: Update sandbox component 'summarizer' to be compatible with latest opennlp-tools release

mawiesne commented on code in PR #76: URL: https://github.com/apache/opennlp-sandbox/pull/76#discussion_r1097617281 ## summarizer/src/main/java/opennlp/summarization/DocProcessor.java: ## @@ -21,17 +21,27 @@ import opennlp.tools.stemmer.Stemmer; -/* +/** * A document proc

[GitHub] [opennlp-sandbox] rzo1 commented on pull request #76: Update sandbox component 'summarizer' to be compatible with latest opennlp-tools release

rzo1 commented on PR #76: URL: https://github.com/apache/opennlp-sandbox/pull/76#issuecomment-1419175156 After this PR is merged, I will going to do a JUnit 4 -> JUnit 5 bulk migration, so @mawiesne can use the JUnit 5 features to fight the toggling tests. -- This is an automated message

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #76: Update sandbox component 'summarizer' to be compatible with latest opennlp-tools release

rzo1 commented on code in PR #76: URL: https://github.com/apache/opennlp-sandbox/pull/76#discussion_r1097444621 ## summarizer/src/main/java/opennlp/summarization/DocProcessor.java: ## @@ -21,17 +21,27 @@ import opennlp.tools.stemmer.Stemmer; -/* +/** * A document processo

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #76: Update sandbox component 'summarizer' to be compatible with latest opennlp-tools release

mawiesne commented on PR #76: URL: https://github.com/apache/opennlp-sandbox/pull/76#issuecomment-1419169102 @kinow I've added a Maven snippet with downloads the wordnet dict archive and extracts it locally to `target/test-classes/wordnet/` so the files are not in the git repo! 2nd benefit:

[GitHub] [opennlp] atarora opened a new pull request, #497: OPENNLP-1373 : Fix CLI examples for CoNLL-2003 on documentation

atarora opened a new pull request, #497: URL: https://github.com/apache/opennlp/pull/497 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x]

[GitHub] [opennlp-sandbox] rzo1 merged pull request #81: Update sandbox component 'opennlp-dl' to be compatible with latest opennlp-tools release

rzo1 merged PR #81: URL: https://github.com/apache/opennlp-sandbox/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apach

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #81: Update sandbox component 'opennlp-dl' to be compatible with latest opennlp-tools release

mawiesne commented on PR #81: URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418864888 > solves the init exception Fixed for all platforms with latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [opennlp-sandbox] rzo1 commented on pull request #81: Update sandbox component 'opennlp-dl' to be compatible with latest opennlp-tools release

rzo1 commented on PR #81: URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418860473 Adding ```java org.nd4j nd4j-native ${nd4j.native.version} ``` solves the init exception for on Linux. Now I get the same excep

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #81: Update sandbox component 'opennlp-dl' to be compatible with latest opennlp-tools release

rzo1 commented on code in PR #81: URL: https://github.com/apache/opennlp-sandbox/pull/81#discussion_r1097099607 ## opennlp-dl/src/main/java/opennlp/tools/dl/NeuralDocCatModel.java: ## @@ -9,16 +33,10 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.io