[GitHub] [opennlp] mawiesne commented on pull request #504: OPENNLP-1470 Modernize maven.yml to fix deprecation warnings

2023-02-17 Thread via GitHub
mawiesne commented on PR #504: URL: https://github.com/apache/opennlp/pull/504#issuecomment-1435509034 Note: Same idea as in `opennlp-sandbox` recently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [opennlp] mawiesne opened a new pull request, #504: OPENNLP-1470 Modernize maven.yml to fix deprecation warnings

2023-02-17 Thread via GitHub
mawiesne opened a new pull request, #504: URL: https://github.com/apache/opennlp/pull/504 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x

[GitHub] [opennlp] mawiesne opened a new pull request, #503: OPENNLP-1469 Update dependency junit-jupiter to version 5.9.2

2023-02-17 Thread via GitHub
mawiesne opened a new pull request, #503: URL: https://github.com/apache/opennlp/pull/503 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x

[GitHub] [opennlp] mawiesne opened a new pull request, #502: OPENNLP-1468 Simplify test assertions in JUnit tests

2023-02-17 Thread via GitHub
mawiesne opened a new pull request, #502: URL: https://github.com/apache/opennlp/pull/502 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x

[GitHub] [opennlp] mawiesne commented on pull request #501: OPENNLP-1467 Update dependency onnxruntime to version 1.14.0

2023-02-17 Thread via GitHub
mawiesne commented on PR #501: URL: https://github.com/apache/opennlp/pull/501#issuecomment-1435324430 @atarora FYI: This dep upgrade would help you locally with 2.1.1-RC2, as _onnxruntime_ only supports M1 Macs from version 1.12.x on. You can override it for local (eval) tests. -- This

[GitHub] [opennlp] mawiesne merged pull request #497: OPENNLP-1373 : Fix CLI examples for CoNLL-2003 on documentation

2023-02-17 Thread via GitHub
mawiesne merged PR #497: URL: https://github.com/apache/opennlp/pull/497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.

Re: [VOTE] Apache OpenNLP 2.1.1 Release Candidate 2

2023-02-17 Thread Atita Arora
Hi, Thank you Jeff for sharing the Eval-test-data and Thanks for sharing the mv Richard. Those are my results : [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running opennlp.dl.doccat.scoring.

[GitHub] [opennlp] mawiesne opened a new pull request, #501: OPENNLP-1467 Update dependency onnxruntime to version 1.14.0

2023-02-17 Thread via GitHub
mawiesne opened a new pull request, #501: URL: https://github.com/apache/opennlp/pull/501 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x

[GitHub] [opennlp] mawiesne opened a new pull request, #500: OPENNLP-1466 Convert the use of Collection#toArray(..) to more performant version under modern JVMs

2023-02-17 Thread via GitHub
mawiesne opened a new pull request, #500: URL: https://github.com/apache/opennlp/pull/500 Change - - converts codebase to use `Collection#toArray(0)` Tasks - Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask yo

[GitHub] [opennlp] mawiesne opened a new pull request, #499: OPENNLP-1465 Clear out unnecessary semicolons from existing classes

2023-02-17 Thread via GitHub
mawiesne opened a new pull request, #499: URL: https://github.com/apache/opennlp/pull/499 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x

[GitHub] [opennlp] mawiesne opened a new pull request, #498: OPENNLP-1464 Update dependency commons-io to version 2.11.0

2023-02-17 Thread via GitHub
mawiesne opened a new pull request, #498: URL: https://github.com/apache/opennlp/pull/498 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x

[GitHub] [opennlp-sandbox] mawiesne opened a new pull request, #85: Modernize classes of sandbox components

2023-02-17 Thread via GitHub
mawiesne opened a new pull request, #85: URL: https://github.com/apache/opennlp-sandbox/pull/85 - modernizes classes to use a Java8+ code style (generics, ...) - rewrites some old c-style array declarations - adds final modifier where applicable - switches to enhanced for-loop patter

Re: [VOTE] Apache OpenNLP 2.1.1 Release Candidate 2

2023-02-17 Thread Jeff Zemerick
Atita, I'll reach out to you about the evaluation test data. Thanks! Jeff On Fri, Feb 17, 2023 at 6:54 AM Richard Zowalla wrote: > For eval tests it would need to be: > > mvn test -DOPENNLP_DATA_DIR=/path/to/opennlp-eval-test-data/ -Peval- > tests > > > > Gruß > Richard > > > > > Am Freitag, de

Re: [VOTE] Apache OpenNLP 2.1.1 Release Candidate 2

2023-02-17 Thread Richard Zowalla
For eval tests it would need to be: mvn test -DOPENNLP_DATA_DIR=/path/to/opennlp-eval-test-data/ -Peval- tests Gruß Richard Am Freitag, dem 17.02.2023 um 12:51 +0100 schrieb Atita Arora: > Hi, > > I ran : > > mvn clean install -Peval-tests -X > > > Apache Maven 3.8.4 (9b656c72d54e5bacbe

Re: [VOTE] Apache OpenNLP 2.1.1 Release Candidate 2

2023-02-17 Thread Atita Arora
Hi, I ran : mvn clean install -Peval-tests -X Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: /opt/homebrew/Cellar/maven/3.8.4/libexec Java version: 17.0.5, vendor: Homebrew, runtime: /opt/homebrew/Cellar/openjdk@17/17.0.5/libexec/openjdk.jdk/Contents/Home Default l