[GitHub] [opennlp-sandbox] kinow commented on a diff in pull request #85: Modernize classes of sandbox components

kinow commented on code in PR #85: URL: https://github.com/apache/opennlp-sandbox/pull/85#discussion_r1112166160 ## opennlp-coref/src/main/java/opennlp/tools/coref/mention/DefaultParse.java: ## @@ -36,12 +36,12 @@ */ public class DefaultParse extends AbstractParse { - publ

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #85: Modernize classes of sandbox components

mawiesne commented on code in PR #85: URL: https://github.com/apache/opennlp-sandbox/pull/85#discussion_r1112193207 ## opennlp-similarity/src/main/java/opennlp/tools/jsmlearning/JSMLearnerOnLatticeWithAbduction.java: ## @@ -17,26 +17,8 @@ package opennlp.tools.jsmlearning; R

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #85: Modernize classes of sandbox components

mawiesne commented on code in PR #85: URL: https://github.com/apache/opennlp-sandbox/pull/85#discussion_r1112192656 ## opennlp-similarity/src/main/java/opennlp/tools/doc_classifier/ClassifierTrainingSetIndexer.java: ## @@ -31,18 +32,18 @@ import org.apache.lucene.index.IndexWri

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #85: Modernize classes of sandbox components

mawiesne commented on code in PR #85: URL: https://github.com/apache/opennlp-sandbox/pull/85#discussion_r1112192021 ## opennlp-coref/src/main/java/opennlp/tools/coref/mention/DefaultParse.java: ## @@ -36,12 +36,12 @@ */ public class DefaultParse extends AbstractParse { - p

Re: [VOTE] Apache OpenNLP 2.1.1 Release Candidate 2

Hi everyone, We are still looking for a third +1 vote (or a -1 vote and a reason to not proceed with the release). Thanks, Jeff On Sat, Feb 18, 2023 at 9:26 AM Jeff Zemerick wrote: > Hi Atita, > > Yes, I think it is an issue with the M1 Mac. Looking at onnxruntime it > says it supports Windows

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #85: Modernize classes of sandbox components

rzo1 commented on code in PR #85: URL: https://github.com/apache/opennlp-sandbox/pull/85#discussion_r938606 ## opennlp-similarity/src/main/java/opennlp/tools/apps/relevanceVocabs/SynonymMap.java: ## @@ -240,7 +240,7 @@ private HashMap createIndex(Map> word ArrayList

[GitHub] [opennlp-sandbox] mawiesne merged pull request #86: Re-adds apache-rat. Cures missing license headers.

mawiesne merged PR #86: URL: https://github.com/apache/opennlp-sandbox/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.a

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #86: Re-adds apache-rat. Cures missing license headers.

rzo1 commented on code in PR #86: URL: https://github.com/apache/opennlp-sandbox/pull/86#discussion_r909659 ## opennlp-similarity/src/main/java/opennlp/tools/similarity/apps/SentenceTranslate.java.txt: ## @@ -208,5 +227,5 @@ public class SentenceTranslate { * @para

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #86: Re-adds apache-rat. Cures missing license headers.

mawiesne commented on PR #86: URL: https://github.com/apache/opennlp-sandbox/pull/86#issuecomment-1436947383 > Yes. Flaky test ;) @kinow @rzo1 I've opened a Jira for this. See: https://issues.apache.org/jira/browse/OPENNLP-1472 -- This is an automated message from the Apache Git Se

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #86: Re-adds apache-rat. Cures missing license headers.

mawiesne commented on code in PR #86: URL: https://github.com/apache/opennlp-sandbox/pull/86#discussion_r873018 ## opennlp-similarity/src/main/java/opennlp/tools/similarity/apps/SentenceTranslate.java.txt: ## @@ -208,5 +227,5 @@ public class SentenceTranslate { * @

[GitHub] [opennlp-sandbox] rzo1 commented on pull request #86: Re-adds apache-rat. Cures missing license headers.

rzo1 commented on PR #86: URL: https://github.com/apache/opennlp-sandbox/pull/86#issuecomment-1436695523 Yes. Flaky test ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [opennlp-sandbox] kinow commented on pull request #86: Re-adds apache-rat. Cures missing license headers.

kinow commented on PR #86: URL: https://github.com/apache/opennlp-sandbox/pull/86#issuecomment-1436693133 @rzo1 >Error:GradientDescentUtilsTest.testConvergence:34 » Runtime failed to converge at it... Is that a brittle test? I seem to recall it being mentioned as failing..

[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #86: Re-adds apache-rat. Cures missing license headers.

rzo1 commented on code in PR #86: URL: https://github.com/apache/opennlp-sandbox/pull/86#discussion_r654757 ## opennlp-similarity/src/main/java/opennlp/tools/similarity/apps/SentenceTranslate.java.txt: ## @@ -208,5 +227,5 @@ public class SentenceTranslate { * @para

[GitHub] [opennlp-sandbox] rzo1 opened a new pull request, #86: Re-adds apache-rat. Cures missing license headers.

rzo1 opened a new pull request, #86: URL: https://github.com/apache/opennlp-sandbox/pull/86 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: -