[GitHub] [opennlp-sandbox] reckart commented on a diff in pull request #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

2023-04-20 Thread via GitHub
reckart commented on code in PR #101: URL: https://github.com/apache/opennlp-sandbox/pull/101#discussion_r1173064041 ## opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/chunker2matcher/ParserChunker2MatcherProcessorTest.java: ## @@ -26,12 +26,17 @@ import opennlp.t

[GitHub] [opennlp-sandbox] mawiesne commented on pull request #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

2023-04-20 Thread via GitHub
mawiesne commented on PR #101: URL: https://github.com/apache/opennlp-sandbox/pull/101#issuecomment-1516912441 > I didn't see the binding being added in the runtime scope in the changes I meant at "test runtime"; will adjust PR description. -- This is an automated message from the A

[GitHub] [opennlp-sandbox] reckart commented on a diff in pull request #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

2023-04-20 Thread via GitHub
reckart commented on code in PR #101: URL: https://github.com/apache/opennlp-sandbox/pull/101#discussion_r1173064041 ## opennlp-similarity/src/test/java/opennlp/tools/textsimilarity/chunker2matcher/ParserChunker2MatcherProcessorTest.java: ## @@ -26,12 +26,17 @@ import opennlp.t

[GitHub] [opennlp-sandbox] reckart commented on pull request #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

2023-04-20 Thread via GitHub
reckart commented on PR #101: URL: https://github.com/apache/opennlp-sandbox/pull/101#issuecomment-1516908800 > introduces log4j-2.x as (managed) runtime binding for slj4j in opennlp-similarity I didn't see the binding being added in the runtime scope in the changes - however, it sho

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

2023-04-20 Thread via GitHub
mawiesne commented on code in PR #101: URL: https://github.com/apache/opennlp-sandbox/pull/101#discussion_r1173057879 ## opennlp-similarity/src/main/java/opennlp/tools/similarity/apps/ContentGeneratorSupport.java: ## @@ -30,13 +29,14 @@ import opennlp.tools.textsimilarity.chun

[GitHub] [opennlp-sandbox] mawiesne commented on a diff in pull request #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

2023-04-20 Thread via GitHub
mawiesne commented on code in PR #101: URL: https://github.com/apache/opennlp-sandbox/pull/101#discussion_r1173057285 ## opennlp-similarity/src/main/java/opennlp/tools/textsimilarity/ParseTreeChunkListScorer.java: ## @@ -78,15 +79,12 @@ public double getScore(ParseTreeChunk chun

[GitHub] [opennlp-sandbox] kinow commented on a diff in pull request #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

2023-04-20 Thread via GitHub
kinow commented on code in PR #101: URL: https://github.com/apache/opennlp-sandbox/pull/101#discussion_r1173050608 ## opennlp-similarity/src/main/java/opennlp/tools/similarity/apps/ContentGeneratorSupport.java: ## @@ -30,13 +29,14 @@ import opennlp.tools.textsimilarity.chunker

[GitHub] [opennlp-sandbox] mawiesne opened a new pull request, #101: OPENNLP-1454 Convert System.out statements to debug logging statements in 'opennlp-similarity'

2023-04-20 Thread via GitHub
mawiesne opened a new pull request, #101: URL: https://github.com/apache/opennlp-sandbox/pull/101 Changes - - replaces many occurrences of Syouts and printStacktrace(), and JUL logging with SLF4J as used in OPENNLP tools - introduces log4j-2.x as (managed) runtime binding for slj4j

Build failed in Jenkins: OpenNLP » eval-tests #51

2023-04-20 Thread Apache Jenkins Server
See Changes: -- [...truncated 9.58 MB...] [main] INFO opennlp.tools.ml.maxent.GISTrainer - 36 - loglikelihood=-20970.843209489547 0.9966707305051181 [main] INFO opennlp.tools.m

Build failed in Jenkins: OpenNLP » eval-tests #50

2023-04-20 Thread Apache Jenkins Server
See Changes: -- [...truncated 12.57 MB...] [main] INFO opennlp.tools.ml.maxent.GISTrainer - 82 - loglikelihood=-173.77247082077437 0.9993777224642191 [main] INFO opennlp.tools.

Re: [VOTE] Apache OpenNLP 2.2.0 Release Candidate

2023-04-20 Thread Jeff Zemerick
Thanks everyone for voting. With 3 +1 binding votes and 3 +1 non-binding votes the release vote was successful. Thanks, Jeff On Thu, Apr 20, 2023 at 6:31 AM Koji Sekiguchi wrote: > +1 > > Koji > > 2023年4月17日(月) 20:49 Richard Zowalla : > > > > Any more votes? Think, that only one binding is miss

Re: [VOTE] Apache OpenNLP 2.2.0 Release Candidate

2023-04-20 Thread Koji Sekiguchi
+1 Koji 2023年4月17日(月) 20:49 Richard Zowalla : > > Any more votes? Think, that only one binding is missing. > > Gruß > Richard > > Am Montag, dem 10.04.2023 um 07:10 -0400 schrieb Jeff Zemerick: > > Hi folks, > > > > I have posted a release candidate for the Apache OpenNLP 2.2.0 > > release and >