mawiesne commented on PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#issuecomment-1398109754
> Added some (non blocking) comments.
@rzo1 Comments resolved where applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mawiesne commented on PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#issuecomment-1397495350
> * senseval3: ~6.9 MB (uncompressed)
>
> * opennlp models: ~8.9 MB (compressed/binary)
@kinow I gziped some plain resource and implemented code to handle reading
in com
mawiesne commented on PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#issuecomment-1397348084
> How large would they be?
- senseval3: ~6.9 MB (uncompressed)
- opennlp models: ~8.9 MB (compressed/binary)
--
This is an automated message from the Apache Git Service.
T
mawiesne commented on PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#issuecomment-1397347783
> How large would they be?
- senseval3: ~6.9 MB (uncompressed)
- opennlp models: ~8.9 MB (compressed/binary)
--
This is an automated message from the Apache Git Service.
T
mawiesne commented on PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#issuecomment-1397202927
> create tests using the large files in a separate suite
Could be covered via a MVN profile in a separate PR.
For now, it would be okay to add those larger (binary) files
mawiesne commented on PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59#issuecomment-1397172400
@kinow I'd like to point your interest to the test resources directory and
the files I added herein. What's your opinion on the bunch of data. IMHO, it is
required to have some sort