Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-17 Thread William Colen
Would be a pleasure. Let's prepare the next OpenNLP RC and I create a PR with the update. 2017-05-16 14:36 GMT-03:00 Richard Eckart de Castilho : > Hi William, > > > On 16.05.2017, at 14:35, William Colen wrote: > > > > I cloned DKPro code and tried

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-16 Thread Richard Eckart de Castilho
Hi William, > On 16.05.2017, at 14:35, William Colen wrote: > > I cloned DKPro code and tried Rodrigo proposed changes. Your test passes > with it. cool :) Would you like to contribute the changes to DKPro Core? Cheers, -- Richard

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-16 Thread William Colen
Hi Richard, I cloned DKPro code and tried Rodrigo proposed changes. Your test passes with it. Thank you William 2017-05-15 18:51 GMT-03:00 Rodrigo Agerri : > Hello Richard, > > I have tried with various corpora, including GUM, but I cannot reproduce > that error. > >

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-15 Thread Rodrigo Agerri
Hello Richard, I have tried with various corpora, including GUM, but I cannot reproduce that error. https://github.com/apache/opennlp/commit/8a3b3b537a30b14c4ffb5eb32ffa41 d5027bddad Please note that commit O-904 changed (broke) the lemmatizer API substantially to make it uniform between

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-15 Thread Joern Kottmann
Good to hear, the parser eval test also had a bug (O-1060), we will fix this now as well before the next RC, this should prevent that this happens again. And thanks again for finding this! Now we need to find the problem with the lemmatizer before we can build the next RC. Jörn On Mon, May

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-15 Thread Richard Eckart de Castilho
> On 15.05.2017, at 16:35, Joern Kottmann wrote: > > Richard, I believe I found the problem with the parser, would you mind to > take a look? > > This PR should fix it: > https://github.com/apache/opennlp/pull/199 The parser test works nicely with the PR. The lemmatizer

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-15 Thread Joern Kottmann
Richard, I believe I found the problem with the parser, would you mind to take a look? This PR should fix it: https://github.com/apache/opennlp/pull/199 Jörn On Mon, May 15, 2017 at 4:14 PM, Richard Eckart de Castilho wrote: > Hi Rodrigo, > > On 15.05.2017, at 15:36, Rodrigo

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-15 Thread Joern Kottmann
Hello Richard, thanks for reporting this. For 1.8.0 we replaced a Heap with a SortedSet [1]. In this commit there is one loop [2] which iterates through the parses which will be advanced. The order of the Parsers in the Heap was not so well defined, therefore we decided to sort them by

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-13 Thread William Colen
With the issues reported by Richard we should cancel the vote and rollback the release. I change my vote to -1 (binding) 2017-05-13 19:08 GMT-03:00 Richard Eckart de Castilho : > > > On 13.05.2017, at 22:35, Richard Eckart de Castilho > wrote: > > > > Should

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-13 Thread Richard Eckart de Castilho
Hi all, > On 11.05.2017, at 18:37, Joern Kottmann wrote: > > The Apache OpenNLP PMC would like to call for a Vote on Apache OpenNLP > 1.8.0 Release Candidate 2. Should OpenNLP 1.8.0 yield identical results as 1.7.2 when the same models are used during classification? E.g.

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-13 Thread Koji Sekiguchi
+1 non-binding Download artifacts, built and executed unit tests successfully on Mac OS X 10.10.5. On 2017/05/12 1:37, Joern Kottmann wrote: The Apache OpenNLP PMC would like to call for a Vote on Apache OpenNLP 1.8.0 Release Candidate 2. The RC 2 distributables can be downloaded from here:

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-12 Thread Daniel Russ
+1 binding Completed my evaluation on my external code. All tests passed. > On May 12, 2017, at 11:51 AM, William Colen wrote: > > +1 binding > Executed the complete evaluation suite, both in source distribution and the > git tag. Integrated and tested with other

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-12 Thread William Colen
+1 binding Executed the complete evaluation suite, both in source distribution and the git tag. Integrated and tested with other tools. 2017-05-12 9:48 GMT-03:00 Joern Kottmann : > The vote is still open and we won't close it before the entire active PMC > voted or the time

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-12 Thread Daniel Russ
Even though we have enough binding votes to release, can I have a few hours to complete testing of my code with 1.8.0RC2 before release. Daniel On May 11, 2017 12:38 PM, "Joern Kottmann" wrote: > The Apache OpenNLP PMC would like to call for a Vote on Apache OpenNLP > 1.8.0

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-12 Thread Jeff Zemerick
+1 non-binding Built and tested on Ubuntu 16.04 and Amazon Linux 2017.03.0 with OpenJDK8. NOTICE and LICENSE files look good. Created and tested a token name finder model. On Fri, May 12, 2017 at 4:42 AM, Tommaso Teofili wrote: > +1 (binding) > > - source distr

Re: [VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-12 Thread Tommaso Teofili
+1 (binding) - source distr build succeeds - build from tag succeeds - signatures and hashes ok Regards, Tommaso Il giorno ven 12 mag 2017 alle ore 01:11 Suneel Marthi ha scritto: > +1 binding > > 1. Downloaded artifacts and ran thru a clean build - all unit tests pass >

[VOTE] Apache OpenNLP 1.8.0 Release Candidate 2

2017-05-11 Thread Joern Kottmann
The Apache OpenNLP PMC would like to call for a Vote on Apache OpenNLP 1.8.0 Release Candidate 2.  The RC 2 distributables can be downloaded from here: https://repository.apache.org/content/repositories/orgapacheopennlp-101 2/org/apache/opennlp/opennlp-distr/1.8.0/ The release was made from the