Re: AdaptiveFeatureGenerator and FeatureGeneratorAdapter

2016-07-05 Thread Jeffrey Zemerick
t; I created a patch to refactor these classes to remove the interface and > use > > the abstract class. (My motivation was I kept getting > > AdaptiveFeatureGenerator and FeatureGeneratorAdapter confused due to > their > > similar naming and the inconsistency of feature generators eithe

Re: AdaptiveFeatureGenerator and FeatureGeneratorAdapter

2016-07-04 Thread Joern Kottmann
classes to remove the interface and use > the abstract class. (My motivation was I kept getting > AdaptiveFeatureGenerator and FeatureGeneratorAdapter confused due to their > similar naming and the inconsistency of feature generators either > implementing or extending.) The project does

AdaptiveFeatureGenerator and FeatureGeneratorAdapter

2016-06-27 Thread Jeffrey Zemerick
kept getting AdaptiveFeatureGenerator and FeatureGeneratorAdapter confused due to their similar naming and the inconsistency of feature generators either implementing or extending.) The project does build and test with the patch applied. If you think this is a worthwhile change I'll submit it on