Re: Suggestion to rename 'isAlphaNumopt' param

2022-10-27 Thread Jeff Zemerick
Hi Atita, thanks for your recent contributions. I support Atita's suggestion that skipAlphaNumOpt is a better name for the parameter since it is more descriptive. This came out of OPENNLP-1387 [1] for getting the documentation consistent with the code. I'm +1 to the change. Thanks, Jeff [1] htt

Suggestion to rename 'isAlphaNumopt' param

2022-10-26 Thread Atita Arora
Hi all, This is my first time writing to the forum and made a few small contributions to the project under the due guidance of my colleague Jeff Zemerick. While going through the documentation and related implementation, I wanted to float an idea of renaming the TrainingParam 'isAlphaNumopt' to 'sk