Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-12 Thread Søren Thing Pedersen
Joerg Barfurth skrev: Søren Thing Pedersen wrote: Hmm. What state will bAssumeEnglishNumbers take if the Office.Calc.Misc.NumberRecognition.AssumeEnglish boolean is not even set in calc.xcu? You have specified a non-null default value in the xcs entry, so that will be used. Currently you h

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-12 Thread Søren Thing Pedersen
Niklas Nebel skrev: "DefaultObjectSize/Width",// SCMISCOPT_DEFOBJWIDTH "DefaultObjectSize/Height"// SCMISCOPT_DEFOBJHEIGHT +"NumberRecognition/AssumeEnglish"// SCMISCOPT_ENGLISHNUMS }; I'd suggest an extra comma here. Thanks. Søren

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-12 Thread Joerg Barfurth
Hi, Søren Thing Pedersen wrote: Eike Rathke skrev: Why initialize first and then immediately assign another value? I'd write that as BOOL bAssumeEnglishNumbers = SC_MOD()->GetAppOptions().GetNumberRecognitionAssumeEnglish() Hmm. What state will bAssumeEnglishNumbers take if the Office.Ca

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-12 Thread Niklas Nebel
Søren Thing Pedersen wrote: Furthermore, a patched build for m128 seems to trigger document recovery everytime Calc is closed as the last OOo application. Did I forget anything? Any usual suspects? { "DefaultObjectSize/Width",// SCMISCOPT_DEFOBJWIDTH

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-11 Thread Søren Thing Pedersen
Søren Thing Pedersen skrev: Eike Rathke skrev: Why initialize first and then immediately assign another value? I'd write that as BOOL bAssumeEnglishNumbers = SC_MOD()->GetAppOptions().GetNumberRecognitionAssumeEnglish() Hmm. What state will bAssumeEnglishNumbers take if the Office.Calc.Mi

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-09 Thread Søren Thing Pedersen
Eike Rathke skrev: Why initialize first and then immediately assign another value? I'd write that as BOOL bAssumeEnglishNumbers = SC_MOD()->GetAppOptions().GetNumberRecognitionAssumeEnglish() Hmm. What state will bAssumeEnglishNumbers take if the Office.Calc.Misc.NumberRecognition.AssumeEngl

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-09 Thread Søren Thing Pedersen
Hi Eike, Eike Rathke skrev: Why initialize first and then immediately assign another value? I'd write that as BOOL bAssumeEnglishNumbers = SC_MOD()->GetAppOptions().GetNumberRecognitionAssumeEnglish() Agreed. Note also the use of bool/true versus BOOL/TRUE, strictly spoken they are differe

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-09 Thread Eike Rathke
Hi Søren, On Thu, Sep 08, 2005 at 19:37:41 +0200, Søren Thing Pedersen wrote: > Many thanks for your easy to follow instructions. I have done as > suggested. Patches attached. Comments are most welcome. Looks ok syntactically, just some nitpicking on style: > +

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-08 Thread Søren Thing Pedersen
Hi Eike, Eike Rathke skrev: If you want to go the hard way and need a configuration entry to be able to control the behavior by some other means, I suggest you add a new node and property to the Office.Calc/Misc options instead, registry/data/org/openoffice/Office/Calc.xcu, and read it by means

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-08 Thread Søren Thing Pedersen
Hi Joerg, Joerg Barfurth skrev: I don't think that is a good place for your setting. The org.openoffice.Office.Linguistic component holds setting for linguistic services. Settings for filters or number parsers and formatters don't belong there. If you really can't find a good place (maybe

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-08 Thread Eike Rathke
Hi Søren, On Wed, Sep 07, 2005 at 21:47:30 +0200, Søren Thing Pedersen wrote: > I want to add a boolean - let's call it AssumeEnglishNumbers - to > /registry/data/org/openoffice/Office/Linguistic.xcu First, as this would only be used by the Calc application, why would you want to add the config

Re: [dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-08 Thread Joerg Barfurth
Hi, Søren Thing Pedersen wrote: I want to add a boolean - let's call it AssumeEnglishNumbers - to /registry/data/org/openoffice/Office/Linguistic.xcu I don't think that is a good place for your setting. The org.openoffice.Office.Linguistic component holds setting for linguistic services.

[dev] Adding boolean to user/registry/data/org/openoffice/Office/Linguistic.xcu

2005-09-07 Thread Søren Thing Pedersen
Hi, I want to add a boolean - let's call it AssumeEnglishNumbers - to /registry/data/org/openoffice/Office/Linguistic.xcu So far I figured I need to prepare the new variable in: svtools/inc/lingucfg.hxx svtools/source/config/lingucfg.cxx svtools/inc/linguprops.hxx I want to check if this vari