[dev] Lock a document for concurrent access?

2007-01-03 Thread Jan Holesovsky
Hi, Please is it possible to lock a document for access of concurrent instances of OOo? I mean the scenario when the document is on a NFS share (read/write), and more users opened it concurrently from their OOo. I'm working on shared workbook functionality, http://www.openoffice.org/issues/s

Re: [dev] Lock a document for concurrent access?

2007-01-08 Thread Mathias Bauer
Jan Holesovsky wrote: > Hi, > > Please is it possible to lock a document for access of concurrent instances of > OOo? I mean the scenario when the document is on a NFS share (read/write), > and more users opened it concurrently from their OOo. I'm working on shared > workbook functionality, > h

Re: [dev] Lock a document for concurrent access?

2007-01-09 Thread Jan Holesovsky
Hi Matthias, Thank you for the valuable feedback! Helps me to sort the ideas. (I've merged your answers into one mail - I hope it's OK.) On Monday 08 January 2007 14:13, Mathias Bauer wrote: > > The lock()/unlock() here would prevent the other OOo instances from > > changing the document whil

Re: [dev] Lock a document for concurrent access?

2007-01-09 Thread Niklas Nebel
Jan Holesovsky wrote: I'm not sure if concurrent access for documents is a good idea. Currently our merging is not perfect and you will have a lot of disappointed users. For me this is doing the second step before the first. Without a better merging we can't offer concurrency. I am a fan of inc

Re: [dev] Lock a document for concurrent access?

2007-01-10 Thread Mathias Bauer
Niklas Nebel wrote: >> Unfortunately it must be. I don't want to open the file again, I >> just want to set/clear the lock, and there's no API for that in >> osl. > > Why not open it again? Treat it more like import/export instead of > load/save, with embedded objects in a temporary storage, an

Re: [dev] Lock a document for concurrent access?

2007-01-10 Thread Mathias Bauer
Jan Holesovsky wrote: >> But then the document can become modified by >> other applications or even deleted by the user while it is still edited >> in an OOo instance. This will let OOo crash in many cases. > > Please remember that no locking was the default until 2.0 > (http://www.openoffice.o

Re: [dev] Lock a document for concurrent access?

2007-01-10 Thread Jan Holesovsky
Hi Niklas, On Tuesday 09 January 2007 20:52, Niklas Nebel wrote: > >> Besides that I don't think that something must be changed in osl. We > >> just have to change our way how we interpret the results from openFile. > > > > Unfortunately it must be. I don't want to open the file again, I just >

Re: [dev] Lock a document for concurrent access?

2007-01-10 Thread Jan Holesovsky
Hi Mathias, On Wednesday 10 January 2007 11:44, Mathias Bauer wrote: > > Please remember that no locking was the default until 2.0 > > (http://www.openoffice.org/issues/show_bug.cgi?id=29425) so I guess if > > this were a real problem, we would have had some crashreports already. > > (Or do we h

Re: [dev] Lock a document for concurrent access?

2007-01-10 Thread Eike Rathke
Hi Mathias, On Wednesday, 2007-01-10 11:44:34 +0100, Mathias Bauer wrote: > > And IIRC - while the file descriptor is still open, the operating system > > (or > > at least Linux) does not unlink the file for the process that owns the file > > descriptor - but I can be wrong of course. > That w

Re: [dev] Lock a document for concurrent access?

2007-01-11 Thread Mathias Bauer
Eike Rathke wrote: > Hi Mathias, > > On Wednesday, 2007-01-10 11:44:34 +0100, Mathias Bauer wrote: > >> > And IIRC - while the file descriptor is still open, the operating system >> > (or >> > at least Linux) does not unlink the file for the process that owns the >> > file >> > descriptor -

Re: [dev] Lock a document for concurrent access?

2007-01-11 Thread Mathias Bauer
Jan Holesovsky wrote: > Hi Niklas, > > On Tuesday 09 January 2007 20:52, Niklas Nebel wrote: > >> >> Besides that I don't think that something must be changed in osl. We >> >> just have to change our way how we interpret the results from openFile. >> > >> > Unfortunately it must be. I don't wan

Re: [dev] Lock a document for concurrent access?

2007-01-11 Thread Mathias Bauer
Jan Holesovsky wrote: > Hi Mathias, > > On Wednesday 10 January 2007 11:44, Mathias Bauer wrote: > >> > Please remember that no locking was the default until 2.0 >> > (http://www.openoffice.org/issues/show_bug.cgi?id=29425) so I guess if >> > this were a real problem, we would have had some cras

Re: [dev] Lock a document for concurrent access?

2007-01-11 Thread Stephan Schaefer
Mathias Bauer wrote: And more over there is no API *below* osl that works on all platforms. So it's quite unlikely that osl will get such an API. Really? fcntl() on unx & Mac OS X, http://msdn2.microsoft.com/en-us/library/aa365203.aspx on Win32, what else? It doesn't work on Win9x. Well, tha

Re: [dev] Lock a document for concurrent access?

2007-01-11 Thread Jan Holesovsky
Hi Mathias, On Thursday 11 January 2007 11:41, Mathias Bauer wrote: > > Interesting. Can you please send me a step-by-step description how to > > reproduce this with locking turned off (unset SAL_ENABLE_FILE_LOCKING). > > That would be extremely helpful. > > The problem was that in OOo1.x we ha

Re: [dev] Lock a document for concurrent access?

2007-01-13 Thread Mathias Bauer
Jan Holesovsky wrote: >> The worst thing that can happen is that a "shared" file is opened by >> another office process that doesn't take part in the sharing and so >> locks the file. This will prevent the "sharing" clients from saving the >> document. Or did I overlook another detail? ;-) > > Go

Re: [dev] Lock a document for concurrent access?

2007-04-18 Thread Niklas Nebel
Jan Holesovsky wrote: Please is it possible to lock a document for access of concurrent instances of OOo? I mean the scenario when the document is on a NFS share (read/write), and more users opened it concurrently from their OOo. I'm working on shared workbook functionality, http://www.openo