Re: [ovs-dev] [PATCH] xenserver: Clean up /usr/sbin/brctl dangling symlink.

2011-02-14 Thread Andrew Evans
On 2/14/11 1:33 PM, Ben Pfaff wrote: > A comment you added refers to a commit by number only. It's better to > add the first line of the commit message, too, e.g.: > # Bug #4667: one-time cleanup of brctl removal in commit 54f16a10 > # (xenserver: Remove brctl wrapper script). Ok, done.

[ovs-dev] [PATCH] ovs-bugtool: Ignore deprecation warnings.

2011-02-14 Thread Ethan Jackson
Since we have to support many versions of Python, this commit forces ovs-bugtool to ignore deprecation warnings. They were complaining about use of the md5 module whose replacement does not appear until Python 2.5. In Python 2.7 deprecation warnings are ignored by default. Bug #4373 --- debian/

Re: [ovs-dev] [db-backup 5/5] Avoid unneeded database compaction at startup, and improve backups.

2011-02-14 Thread Ethan Jackson
> > I tested the xenserver version but not the Debian version. > --- >  debian/openvswitch-switch.init   |   13 - >  xenserver/etc_init.d_openvswitch |   15 --- >  2 files changed, 16 insertions(+), 12 deletions(-) > > diff --git a/debian/openvswitch-switch.init b/debian/ope

Re: [ovs-dev] [db-backup 4/5] ovsdb-tool: New command "needs-conversion".

2011-02-14 Thread Ethan Jackson
Looks Good. On Tue, Feb 8, 2011 at 4:00 PM, Ben Pfaff wrote: > --- >  ovsdb/ovsdb-tool.1.in |    7 +++ >  ovsdb/ovsdb-tool.c    |   15 +++ >  ovsdb/ovsdb.c         |   17 + >  ovsdb/ovsdb.h         |    3 +++ >  tests/ovsdb-tool.at   |   22 ++ >

Re: [ovs-dev] [db-backup 3/5] ovsdb-tool: Add commands for printing the database checksum.

2011-02-14 Thread Ethan Jackson
Looks Good. On Tue, Feb 8, 2011 at 4:00 PM, Ben Pfaff wrote: > --- >  ovsdb/SPECS              |    4 >  ovsdb/ovsdb-tool.1.in    |   31 +++ >  ovsdb/ovsdb-tool.c       |   26 ++ >  ovsdb/ovsdb.c            |   18 -- >  ovsd

Re: [ovs-dev] [resubmit 1/4] ofproto: flow_stats_ds() print flows properly.

2011-02-14 Thread Ben Pfaff
Sounds good, thank you. On Mon, Feb 14, 2011 at 03:42:09PM -0800, Ethan Jackson wrote: > I will go ahead and change it to ds_put_char before merging. > > Ethan > > On Mon, Feb 14, 2011 at 3:28 PM, Ben Pfaff wrote: > > On Mon, Feb 14, 2011 at 02:05:58PM -0800, Ethan Jackson wrote: > >> @@ -3668,

Re: [ovs-dev] [resubmit 2/4] ofproto: Display idle time in bridge/dump-flows.

2011-02-14 Thread Ben Pfaff
On Mon, Feb 14, 2011 at 03:39:29PM -0800, Ethan Jackson wrote: > ds_put_format(results, "duration=%llds, ", >(time_msec() - rule->created) / 1000); > +ds_put_format(results, "idle=%.3fs, ", (time_msec() - rule->used) / > 1000.0); > ds_put_format(results, "priority

Re: [ovs-dev] [resubmit 1/4] ofproto: flow_stats_ds() print flows properly.

2011-02-14 Thread Ethan Jackson
I will go ahead and change it to ds_put_char before merging. Ethan On Mon, Feb 14, 2011 at 3:28 PM, Ben Pfaff wrote: > On Mon, Feb 14, 2011 at 02:05:58PM -0800, Ethan Jackson wrote: >> @@ -3668,6 +3668,7 @@ flow_stats_ds(struct ofproto *ofproto, struct rule >> *rule, struct ds *results) >>    

[ovs-dev] [resubmit 2/4] ofproto: Display idle time in bridge/dump-flows.

2011-02-14 Thread Ethan Jackson
--- ofproto/ofproto.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 88cae75..589f80c 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -3664,6 +3664,7 @@ flow_stats_ds(struct ofproto *ofproto, struct rule *rule, struct

Re: [ovs-dev] [resubmit 2/4] ofproto: Display idle time in bridge/dump-flows.

2011-02-14 Thread Ben Pfaff
On Mon, Feb 14, 2011 at 02:05:59PM -0800, Ethan Jackson wrote: > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c > index 305af35..3a74f79 100644 > --- a/ofproto/ofproto.c > +++ b/ofproto/ofproto.c > @@ -3664,6 +3664,7 @@ flow_stats_ds(struct ofproto *ofproto, struct rule > *rule, struct ds *res

Re: [ovs-dev] [resubmit 1/4] ofproto: flow_stats_ds() print flows properly.

2011-02-14 Thread Ben Pfaff
On Mon, Feb 14, 2011 at 02:05:58PM -0800, Ethan Jackson wrote: > @@ -3668,6 +3668,7 @@ flow_stats_ds(struct ofproto *ofproto, struct rule > *rule, struct ds *results) > ds_put_format(results, "n_packets=%"PRIu64", ", packet_count); > ds_put_format(results, "n_bytes=%"PRIu64", ", byte_cou

Re: [ovs-dev] [db-backup 2/5] ovsdb: New function ovsdb_file_read_schema() for reading schema from db.

2011-02-14 Thread Ethan Jackson
Looks Good. On Tue, Feb 8, 2011 at 4:00 PM, Ben Pfaff wrote: > This new function saves reading the whole database when only the schema is > of interest.  This commit adapts ovsdb-tool to use it for the "db-version" > command.  Upcoming commits will introduce another caller. > --- >  ovsdb/file.c

[ovs-dev] [resubmit 1/4] ofproto: flow_stats_ds() print flows properly.

2011-02-14 Thread Ethan Jackson
--- ofproto/ofproto.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 39d3457..305af35 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -3668,6 +3668,7 @@ flow_stats_ds(struct ofproto *ofproto, struct rule *rule, struct

[ovs-dev] [resubmit 3/4] ofproto: Batch statistics updates.

2011-02-14 Thread Ethan Jackson
Facet statistics are updated once per second during ofproto_expire() instead of upon request. This will greatly simplify implementation of future patches. This commit also changes each facet's packet and byte counters to include the statistics stored in the datapath. --- ofproto/ofproto.c | 130

[ovs-dev] [resubmit 4/4] ofproto: Resubmit Statistics.

2011-02-14 Thread Ethan Jackson
This patch causes statistics to be updated for rules which are resubmitted into. Once per second statistics are queried from the datapath and pushed along the resubmit graph (calculated on demand from the action list). This approach is simple, easy to understand, and in most cases accurate. Howev

[ovs-dev] [resubmit 2/4] ofproto: Display idle time in bridge/dump-flows.

2011-02-14 Thread Ethan Jackson
--- ofproto/ofproto.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 305af35..3a74f79 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -3664,6 +3664,7 @@ flow_stats_ds(struct ofproto *ofproto, struct rule *rule, struct

Re: [ovs-dev] [PATCH] xenserver: Clean up /usr/sbin/brctl dangling symlink.

2011-02-14 Thread Ben Pfaff
On Mon, Feb 14, 2011 at 01:09:46PM -0800, Andrew Evans wrote: > Commit 54f16a10 removed Open vSwitch's /usr/sbin/brctl replacement for > XenServer, but because the RPM doesn't restore the original files on upgrade, > an upgrade leaves /usr/sbin/brctl a broken symlink to the removed > /usr/share/ope

[ovs-dev] [PATCH] xenserver: Clean up /usr/sbin/brctl dangling symlink.

2011-02-14 Thread Andrew Evans
Commit 54f16a10 removed Open vSwitch's /usr/sbin/brctl replacement for XenServer, but because the RPM doesn't restore the original files on upgrade, an upgrade leaves /usr/sbin/brctl a broken symlink to the removed /usr/share/openvswitch/scripts/brctl. This commit adds a one-time cleanup to restor

Re: [ovs-dev] [PATCH] xenserver: Replace customized xen-bugtool with plugin to collect qdisc info.

2011-02-14 Thread Ben Pfaff
On Fri, Feb 11, 2011 at 07:24:10PM -0800, Andrew Evans wrote: > XenServer RPMs have installed a modified /usr/sbin/xen-bugtool that is > identical to upstream except for an additional command to collect tc qdisc > class configuration for each network interface. Since xen-bugtool has an > extension