Re: [ovs-dev] [PATCH 2/2] ofp-util: Rename struct flow_stats_request with ofputil_ prefix.

2011-08-10 Thread Justin Pettit
The series looks good. There are a mix of functions that use and don't use that convention, but it's certainly nothing urgent. Cleaning up the structures is more important. --Justin On Aug 9, 2011, at 1:53 PM, Ben Pfaff wrote: Most of the structs in ofp-util.h have the ofputil_ prefix.

[ovs-dev] 行政能力素质模型与建设

2011-08-10 Thread 行政统筹管理实操训练
行政统筹管理实操训练 ― 时间地点：2011年08月19-20日　北京 时间地点：2011年09月09-10日　深圳 时间地点：2011年09月16-17日　上海 时间地点：2011年10月21-22日　北京 时间地点：2011年10月28-29日　深圳 时间地点：2011年11月11-12日　上海 时间地点：2011年11月25-26日　北京 时间地点：2011年12月09-10日　深圳 时间地点：2011年12月16-17日　上海

Re: [ovs-dev] branch-1.2 commits

2011-08-10 Thread Ben Pfaff
On Wed, Aug 10, 2011 at 12:34:56AM -0700, Justin Pettit wrote: On Aug 9, 2011, at 2:01 PM, Ben Pfaff wrote: On Tue, Aug 09, 2011 at 01:35:08PM -0700, Ben Pfaff wrote: e89993f ovs-ofctl: Fix reading flows from file for replace-flows, diff-flows. 8402c74 Option to forward BPDU (Ethernet

Re: [ovs-dev] Bug#636816: ovsdbmonitor and openvswitch-switch: error when trying to install together

2011-08-10 Thread Ben Pfaff
On Sat, Aug 06, 2011 at 06:03:13AM +0200, Ralf Treinen wrote: dpkg: error processing /var/cache/apt/archives/ovsdbmonitor_1.2.0-1_all.deb (--unpack): trying to overwrite '/usr/share/openvswitch/vswitch.ovsschema', which is also in package openvswitch-switch 1.2.0-1 Thank you for the

Re: [ovs-dev] [PATCH] debian: Avoid installing duplicate files in ovsdbmonitor package.

2011-08-10 Thread Justin Pettit
Looks reasonable to me. --Justin On Aug 10, 2011, at 9:13 AM, Ben Pfaff wrote: This is just a typo introduced in commit 57483aeda (debian: Fix bug from commit 211b05b5 debian: Modernize use of dh_install.) that caused the ovsdbmonitor package to install too many files. Bug-report:

Re: [ovs-dev] [PATCH] debian: Avoid installing duplicate files in ovsdbmonitor package.

2011-08-10 Thread Ben Pfaff
Thanks, I pushed this to master and branch-1.2. On Wed, Aug 10, 2011 at 01:36:01PM -0700, Justin Pettit wrote: Looks reasonable to me. --Justin On Aug 10, 2011, at 9:13 AM, Ben Pfaff wrote: This is just a typo introduced in commit 57483aeda (debian: Fix bug from commit 211b05b5

[ovs-dev] [PATCH 1/2] dpif-netdev: Avoid pointlessly maintaining a port count.

2011-08-10 Thread Ben Pfaff
'n_ports' was only used for testing for nonzero, and we can rewrite the code that does that to more straightforwardly use LIST_FOR_EACH_SAFE. --- lib/dpif-netdev.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index

[ovs-dev] [PATCH] connmgr: Remove unused function ofconn_n_pending_opgroups().

2011-08-10 Thread Ben Pfaff
--- ofproto/connmgr.c |7 --- ofproto/connmgr.h |1 - 2 files changed, 0 insertions(+), 8 deletions(-) diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c index 38052ac..2d0b8c5 100644 --- a/ofproto/connmgr.c +++ b/ofproto/connmgr.c @@ -849,13 +849,6 @@

[ovs-dev] Processed: Bug #636815: fixed in upstream Git repo

2011-08-10 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: tags 636815 + fixed-upstream Bug #636815 [openvswitch-common,ovsdbmonitor] ovsdbmonitor and openvswitch-common: error when trying to install together Added tag(s) fixed-upstream. thanks Stopping processing here. Please contact me if you need

[ovs-dev] [PATCH 2/6] tests: Update gitignore.

2011-08-10 Thread Ethan Jackson
--- tests/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/.gitignore b/tests/.gitignore index 9f939c2..1454dac 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -22,6 +22,7 @@ /test-list /test-lockfile /test-multipath +/test-odp /test-openflowd

[ovs-dev] [PATCH 3/6] flow: New FLOW_WC_SEQ build assertion.

2011-08-10 Thread Ethan Jackson
Changing struct flow or its wildcards requires minor adjustments in many places in the code. This patch adds a new FLOW_WC_SEQ sequence number which when incremented will cause build assertion failures aiding the developer in finding code which needs to change. --- lib/classifier.c |6 --

[ovs-dev] [PATCH 1/6] lib: Whitespace cleanup.

2011-08-10 Thread Ethan Jackson
--- lib/classifier.c |6 +++--- lib/flow.c |4 ++-- lib/learning-switch.c |2 +- lib/netdev.c |2 +- lib/odp-util.c |2 +- lib/util.c |2 +- ofproto/netflow.c |2 +- ofproto/ofproto-dpif.c |6 +++---

[ovs-dev] [PATCH 5/6] nx-match: New function nxm_read_field().

2011-08-10 Thread Ethan Jackson
nxm_read_field() simplifies reading of NXM fields with an ofs_nbits parameter. This patch updates nxm_execute_reg_move() to use the new function. A user outside of the nx-match module will be added in future patches. --- lib/nx-match.c | 38 ++

Re: [ovs-dev] [PATCH 6/6] nicra-ext: New action NXAST_OUTPUT_REG.

2011-08-10 Thread Ethan Jackson
The NXAST_OUTPUT_REG outputs to the OpenFlow port contained in a supplied NXM field. This should read: The NXAST_OUTPUT_REG action outputs to the OpenFlow port contained in a supplied NXM field. ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 1/6] lib: Whitespace cleanup.

2011-08-10 Thread Ben Pfaff
On Wed, Aug 10, 2011 at 05:21:38PM -0700, Ethan Jackson wrote: --- lib/classifier.c |6 +++--- lib/flow.c |4 ++-- lib/learning-switch.c |2 +- lib/netdev.c |2 +- lib/odp-util.c |2 +- lib/util.c |2 +-

Re: [ovs-dev] [PATCH 2/6] tests: Update gitignore.

2011-08-10 Thread Ben Pfaff
On Wed, Aug 10, 2011 at 05:21:39PM -0700, Ethan Jackson wrote: diff --git a/tests/.gitignore b/tests/.gitignore index 9f939c2..1454dac 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -22,6 +22,7 @@ /test-list /test-lockfile /test-multipath +/test-odp /test-openflowd

Re: [ovs-dev] [PATCH 3/6] flow: New FLOW_WC_SEQ build assertion.

2011-08-10 Thread Ben Pfaff
On Wed, Aug 10, 2011 at 05:21:40PM -0700, Ethan Jackson wrote: Changing struct flow or its wildcards requires minor adjustments in many places in the code. This patch adds a new FLOW_WC_SEQ sequence number which when incremented will cause build assertion failures aiding the developer in