Re: [ovs-dev] Error create module with kernel 3.0.x

2011-08-16 Thread Jesse Gross
On Tue, Aug 16, 2011 at 5:10 PM, Anthony Demard anthony.dem...@pixs.fr wrote: Package: openvswitch-datapath-source Version: 1.1.1-1 Install OK -- aptitude install openvswitch-datapath-source But after install i launch the commad -- module-assistant auto-install openvswitch-datapath And

[ovs-dev] [PATCH] ofproto: Clear packet and byte counters on flow additions.

2011-08-16 Thread Ethan Jackson
When a flow is added to the flow table, its packet and byte counters should be reset. This patch efficiently approximates this behavior. It also does some minor code refactoring. Bug #3183. --- ofproto/ofproto-dpif.c | 24 +++- 1 files changed, 19 insertions(+), 5

Re: [ovs-dev] [PATCH] ofproto: Clear packet and byte counters on flow additions.

2011-08-16 Thread Ben Pfaff
On Tue, Aug 16, 2011 at 01:57:18PM -0700, Ethan Jackson wrote: When a flow is added to the flow table, its packet and byte counters should be reset. This patch efficiently approximates this behavior. It also does some minor code refactoring. Bug #3183. Seems reasonable. Thanks. I

[ovs-dev] [PATCH 0/3] Facet accounting and comment updates.

2011-08-16 Thread Ethan Jackson
The first patch of this series fixes a bug I noticed involving facet_account(). The second patch in the series would have fixed it as well. I wrote them as two patches in case we want to backport it to 1.2. I don't have a strong opinion either way on that matter. Ethan Jackson (3): ofproto:

[ovs-dev] [PATCH 1/3] ofproto: Fix over accounting of byte counters.

2011-08-16 Thread Ethan Jackson
The update_stats() function in ofproto was attributing more bytes to facets than they had actually accrued. This could potentially throw off bond load balancing. Found by inspection. --- ofproto/ofproto-dpif.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[ovs-dev] [PATCH 2/3] ofproto: Remove extra_bytes parameter of facet_account().

2011-08-16 Thread Ethan Jackson
It no longer has interesting users. --- ofproto/ofproto-dpif.c | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 3aa0e78..a181122 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@

[ovs-dev] [PATCH 3/3] ofproto: Update 'struct facet''s comments.

2011-08-16 Thread Ethan Jackson
Some of the comments in the definition of 'struct facet' had become out of date. --- ofproto/ofproto-dpif.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index a181122..3fd95ea 100644 --- a/ofproto/ofproto-dpif.c

[ovs-dev] [prelearning 1/5] packets: Add more utility functions for IPv4 and IPv6 addresses.

2011-08-16 Thread Ben Pfaff
We had these functions scattered around the source tree anyway. packets.h is a good place to centralize them. I do plan to introduce some additional callers. --- lib/classifier.c | 22 ++--- lib/ofp-util.c | 16 ++-- lib/packets.c| 65

[ovs-dev] [prelearning 0/5] cleanup prior to adding learning action

2011-08-16 Thread Ben Pfaff
I'm working on a new action that will allow a controller to do more advanced learning than is currently possible with OFPP_NORMAL. This series is a set of cleanups that I made along the way. Ben Pfaff (5): packets: Add more utility functions for IPv4 and IPv6 addresses. ofp-util: New

[ovs-dev] [prelearning 5/5] ofp-util: Add type-safe functions for serializing actions.

2011-08-16 Thread Ben Pfaff
--- lib/autopath.c |6 +-- lib/bundle.c|7 +-- lib/multipath.c |6 +-- lib/nx-match.c | 10 + lib/ofp-parse.c | 124 --- lib/ofp-util.c | 59 -- lib/ofp-util.h | 24 +++ 7 files

Re: [ovs-dev] [prelearning 2/5] ofp-util: New functions for parsing and formatting OpenFlow port numbers.

2011-08-16 Thread Ethan Jackson
Looks good, Ethan On Tue, Aug 16, 2011 at 16:29, Ben Pfaff b...@nicira.com wrote: These functions were previously used only in ofp-parse.c and ofp-print.c, but they are more generally useful and future commits will add more users. ---  lib/ofp-parse.c |   39 ++---

Re: [ovs-dev] [prelearning 3/5] ofp-util: Further abstract definitions of action properties.

2011-08-16 Thread Ethan Jackson
Looks good, I would be inclined to s/false/0 and s/true/1 in ofp-util.def. That would allow us to align it against NXAST_RESUBMIT_TABLE without going over 79 characters. Doesn't really matter though. Ethan On Tue, Aug 16, 2011 at 16:29, Ben Pfaff b...@nicira.com wrote: This commit primarily

Re: [ovs-dev] [prelearning 4/5] ofp-parse: Refactor action parsing to improve compiler warnings.

2011-08-16 Thread Ethan Jackson
Looks good. Ethan On Tue, Aug 16, 2011 at 16:29, Ben Pfaff b...@nicira.com wrote: When a new action is added, compiler warnings show most of the places that need new code to handle that action.  The action parsing code in ofp-parse.c was the one remaining missing case.  This commit fixes